Commit c8b838d1 authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Saeed Mahameed
Browse files

net/mlx5: Use fallthrough pseudo-keyword 

Replace the existing /* fall through */ comments and its variants with
the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
fall-through markings when it is the case.

[1] https://www.kernel.org/doc/html/v5.7/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through



Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
parent ffdc8ec0

drivers/net/ethernet/mellanox/mlx5/core/en/txrx.h

+1 −1
Original line number Diff line number Diff line
@@ -388,7 +388,7 @@ mlx5e_set_eseg_swp(struct sk_buff *skb, struct mlx5_wqe_eth_seg *eseg, 
	switch (swp_spec->tun_l4_proto) {

	case IPPROTO_UDP:

		eseg->swp_flags |= MLX5_ETH_WQE_SWP_INNER_L4_UDP;

		/* fall through */

		fallthrough;

	case IPPROTO_TCP:

		eseg->swp_inner_l4_offset = skb_inner_transport_offset(skb) / 2;

		break;

drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c

+2 −2
Original line number Diff line number Diff line
@@ -152,11 +152,11 @@ bool mlx5e_xdp_handle(struct mlx5e_rq *rq, struct mlx5e_dma_info *di, 
		return true;

	default:

		bpf_warn_invalid_xdp_action(act);

		/* fall through */

		fallthrough;

	case XDP_ABORTED:

xdp_abort:

		trace_xdp_exception(rq->netdev, prog, act);

		/* fall through */

		fallthrough;

	case XDP_DROP:

		rq->stats->xdp_drop++;

		return true;

drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls_tx.c

+1 −1
Original line number Diff line number Diff line
@@ -470,7 +470,7 @@ bool mlx5e_ktls_handle_tx_skb(struct tls_context *tls_ctx, struct mlx5e_txqsq *s 
			if (likely(!skb->decrypted))

				goto out;

			WARN_ON_ONCE(1);

			/* fall-through */

			fallthrough;

		case MLX5E_KTLS_SYNC_FAIL:

			goto err_out;

		}

drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c

+1 −1
Original line number Diff line number Diff line
@@ -243,7 +243,7 @@ int mlx5e_ethtool_get_sset_count(struct mlx5e_priv *priv, int sset) 
		return MLX5E_NUM_PFLAGS;

	case ETH_SS_TEST:

		return mlx5e_self_test_num(priv);

	/* fallthrough */

		fallthrough;

	default:

		return -EOPNOTSUPP;

	}

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c

+1 −1
Original line number Diff line number Diff line
@@ -2346,7 +2346,7 @@ int mlx5_devlink_eswitch_inline_mode_set(struct devlink *devlink, u8 mode, 
	case MLX5_CAP_INLINE_MODE_NOT_REQUIRED:

		if (mode == DEVLINK_ESWITCH_INLINE_MODE_NONE)

			goto out;

		/* fall through */

		fallthrough;

	case MLX5_CAP_INLINE_MODE_L2:

		NL_SET_ERR_MSG_MOD(extack, "Inline mode can't be set");

		err = -EOPNOTSUPP;