Commit c8b26393 authored by Deborah Brouwer's avatar Deborah Brouwer Committed by Mauro Carvalho Chehab
Browse files

media: cec-pin: rename timer overrun variables 



The cec pin timer overruns are measured in microseconds, but the variable
names include the millisecond symbol "ms". To avoid confusion, replace
"ms" with "us" in the variable names and printed status message.

Signed-off-by: default avatarDeborah Brouwer <deborahbrouwer3563@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 5cdd19bb

drivers/media/cec/core/cec-pin-priv.h

+2 −2
Original line number Diff line number Diff line
@@ -209,8 +209,8 @@ struct cec_pin { 
	u32				work_pin_events_dropped_cnt;

	ktime_t				timer_ts;

	u32				timer_cnt;

	u32				timer_100ms_overruns;

	u32				timer_300ms_overruns;

	u32				timer_100us_overruns;

	u32				timer_300us_overruns;

	u32				timer_max_overrun;

	u32				timer_sum_overrun;

drivers/media/cec/core/cec-pin.c

+10 −10
Original line number Diff line number Diff line
@@ -854,9 +854,9 @@ static enum hrtimer_restart cec_pin_timer(struct hrtimer *timer) 
		if (delta > 100 && pin->state != CEC_ST_IDLE) {

			/* Keep track of timer overruns */

			pin->timer_sum_overrun += delta;

			pin->timer_100ms_overruns++;

			pin->timer_100us_overruns++;

			if (delta > 300)

				pin->timer_300ms_overruns++;

				pin->timer_300us_overruns++;

			if (delta > pin->timer_max_overrun)

				pin->timer_max_overrun = delta;

		}
@@ -1207,15 +1207,15 @@ static void cec_pin_adap_status(struct cec_adapter *adap, 
	seq_printf(file, "cec pin events dropped: %u\n",

		   pin->work_pin_events_dropped_cnt);

	seq_printf(file, "irq failed: %d\n", pin->enable_irq_failed);

	if (pin->timer_100ms_overruns) {

		seq_printf(file, "timer overruns > 100ms: %u of %u\n",

			   pin->timer_100ms_overruns, pin->timer_cnt);

		seq_printf(file, "timer overruns > 300ms: %u of %u\n",

			   pin->timer_300ms_overruns, pin->timer_cnt);

	if (pin->timer_100us_overruns) {

		seq_printf(file, "timer overruns > 100us: %u of %u\n",

			   pin->timer_100us_overruns, pin->timer_cnt);

		seq_printf(file, "timer overruns > 300us: %u of %u\n",

			   pin->timer_300us_overruns, pin->timer_cnt);

		seq_printf(file, "max timer overrun: %u usecs\n",

			   pin->timer_max_overrun);

		seq_printf(file, "avg timer overrun: %u usecs\n",

			   pin->timer_sum_overrun / pin->timer_100ms_overruns);

			   pin->timer_sum_overrun / pin->timer_100us_overruns);

	}

	if (pin->rx_start_bit_low_too_short_cnt)

		seq_printf(file,
@@ -1245,8 +1245,8 @@ static void cec_pin_adap_status(struct cec_adapter *adap, 
	seq_printf(file, "tx detected low drive: %u\n", pin->tx_low_drive_cnt);

	pin->work_pin_events_dropped_cnt = 0;

	pin->timer_cnt = 0;

	pin->timer_100ms_overruns = 0;

	pin->timer_300ms_overruns = 0;

	pin->timer_100us_overruns = 0;

	pin->timer_300us_overruns = 0;

	pin->timer_max_overrun = 0;

	pin->timer_sum_overrun = 0;

	pin->rx_start_bit_low_too_short_cnt = 0;