Commit c87d175d authored by Yangtao Li's avatar Yangtao Li Committed by Jan Kara
Browse files

quota: make dquot_set_dqinfo return errors from ->write_info 



dquot_set_dqinfo() ignores the return code from the ->write_info
call, which means that quotacalls like Q_SETINFO never see the error.
This doesn't seem right, so fix that.

Signed-off-by: default avatarYangtao Li <frank.li@vivo.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
Message-Id: <20230227120216.31306-2-frank.li@vivo.com>
parent f8107c99

fs/quota/dquot.c

+1 −3
Original line number Diff line number Diff line
@@ -2819,7 +2819,6 @@ EXPORT_SYMBOL(dquot_get_state); 
int dquot_set_dqinfo(struct super_block *sb, int type, struct qc_info *ii)

{

	struct mem_dqinfo *mi;

	int err = 0;



	if ((ii->i_fieldmask & QC_WARNS_MASK) ||

	    (ii->i_fieldmask & QC_RT_SPC_TIMER))
@@ -2846,8 +2845,7 @@ int dquot_set_dqinfo(struct super_block *sb, int type, struct qc_info *ii) 
	spin_unlock(&dq_data_lock);

	mark_info_dirty(sb, type);

	/* Force write to disk */

	sb->dq_op->write_info(sb, type);

	return err;

	return sb->dq_op->write_info(sb, type);

}

EXPORT_SYMBOL(dquot_set_dqinfo);