Commit c85b2f15 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski
Browse files

Merge tag 'intel-gpio-v5.19-1' of... 

Merge tag 'intel-gpio-v5.19-1' of git://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-gpio-intel into gpio/for-next

intel-gpio for v5.19-1

* Introduce helpers to iterate over GPIO chip nodes and covert some drivers

gpiolib:
 -  Introduce a helper to get first GPIO controller node
 -  Introduce gpiochip_node_count() helper
 -  Introduce for_each_gpiochip_node() loop helper

pinctrl:
 -  meson: Replace custom code by gpiochip_node_count() call
 -  meson: Enable COMPILE_TEST
 -  meson: Rename REG_* to MESON_REG_*
 -  armada-37xx: Reuse GPIO fwnode in armada_37xx_irqchip_register()
 -  armada-37xx: Switch to use fwnode instead of of_node
 -  samsung: Switch to use for_each_gpiochip_node() helper
 -  samsung: Drop redundant node parameter in samsung_banks_of_node_get()
 -  npcm7xx: Switch to use for_each_gpiochip_node() helper
 -  renesas: rza1: Switch to use for_each_gpiochip_node() helper
 -  renesas: rza1: Replace custom code by gpiochip_node_count() call
 -  stm32: Switch to use for_each_gpiochip_node() helper
 -  stm32: Replace custom code by gpiochip_node_count() call
parents 2e9cf845 edc5601d

drivers/gpio/gpiolib-acpi.c

+12 −10
Original line number Diff line number Diff line
@@ -108,7 +108,7 @@ static int acpi_gpiochip_find(struct gpio_chip *gc, void *data) 
 * controller does not have GPIO chip registered at the moment. This is to

 * support probe deferral.

 */

static struct gpio_desc *acpi_get_gpiod(char *path, int pin)

static struct gpio_desc *acpi_get_gpiod(char *path, unsigned int pin)

{

	struct gpio_chip *chip;

	acpi_handle handle;
@@ -136,7 +136,7 @@ static struct gpio_desc *acpi_get_gpiod(char *path, int pin) 
 * as it is intended for use outside of the GPIO layer (in a similar fashion to

 * gpiod_get_index() for example) it also holds a reference to the GPIO device.

 */

struct gpio_desc *acpi_get_and_request_gpiod(char *path, int pin, char *label)

struct gpio_desc *acpi_get_and_request_gpiod(char *path, unsigned int pin, char *label)

{

	struct gpio_desc *gpio;

	int ret;
@@ -317,11 +317,12 @@ static struct gpio_desc *acpi_request_own_gpiod(struct gpio_chip *chip, 
	return desc;

}



static bool acpi_gpio_in_ignore_list(const char *controller_in, int pin_in)

static bool acpi_gpio_in_ignore_list(const char *controller_in, unsigned int pin_in)

{

	const char *controller, *pin_str;

	int len, pin;

	unsigned int pin;

	char *endp;

	int len;



	controller = ignore_wake;

	while (controller) {
@@ -354,13 +355,13 @@ static bool acpi_gpio_in_ignore_list(const char *controller_in, int pin_in) 
static bool acpi_gpio_irq_is_wake(struct device *parent,

				  struct acpi_resource_gpio *agpio)

{

	int pin = agpio->pin_table[0];

	unsigned int pin = agpio->pin_table[0];



	if (agpio->wake_capable != ACPI_WAKE_CAPABLE)

		return false;



	if (acpi_gpio_in_ignore_list(dev_name(parent), pin)) {

		dev_info(parent, "Ignoring wakeup on pin %d\n", pin);

		dev_info(parent, "Ignoring wakeup on pin %u\n", pin);

		return false;

	}
@@ -378,7 +379,8 @@ static acpi_status acpi_gpiochip_alloc_event(struct acpi_resource *ares, 
	struct acpi_gpio_event *event;

	irq_handler_t handler = NULL;

	struct gpio_desc *desc;

	int ret, pin, irq;

	unsigned int pin;

	int ret, irq;



	if (!acpi_gpio_get_irq_resource(ares, &agpio))

		return AE_OK;
@@ -387,8 +389,8 @@ static acpi_status acpi_gpiochip_alloc_event(struct acpi_resource *ares, 
	pin = agpio->pin_table[0];



	if (pin <= 255) {

		char ev_name[5];

		sprintf(ev_name, "_%c%02hhX",

		char ev_name[8];

		sprintf(ev_name, "_%c%02X",

			agpio->triggering == ACPI_EDGE_SENSITIVE ? 'E' : 'L',

			pin);

		if (ACPI_SUCCESS(acpi_get_handle(handle, ev_name, &evt_handle)))
@@ -1098,7 +1100,7 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address, 


	length = min_t(u16, agpio->pin_table_length, pin_index + bits);

	for (i = pin_index; i < length; ++i) {

		int pin = agpio->pin_table[i];

		unsigned int pin = agpio->pin_table[i];

		struct acpi_gpio_connection *conn;

		struct gpio_desc *desc;

		bool found;

drivers/pinctrl/meson/Kconfig

+1 −1
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only

menuconfig PINCTRL_MESON

	tristate "Amlogic SoC pinctrl drivers"

	depends on ARCH_MESON

	depends on ARCH_MESON || COMPILE_TEST

	depends on OF

	default y

	select PINMUX

drivers/pinctrl/meson/pinctrl-meson.c

+24 −28
Original line number Diff line number Diff line
@@ -49,6 +49,7 @@ 
#include <linux/pinctrl/pinctrl.h>

#include <linux/pinctrl/pinmux.h>

#include <linux/platform_device.h>

#include <linux/property.h>

#include <linux/regmap.h>

#include <linux/seq_file.h>
@@ -218,13 +219,13 @@ static int meson_pinconf_set_output(struct meson_pinctrl *pc, 
				    unsigned int pin,

				    bool out)

{

	return meson_pinconf_set_gpio_bit(pc, pin, REG_DIR, !out);

	return meson_pinconf_set_gpio_bit(pc, pin, MESON_REG_DIR, !out);

}



static int meson_pinconf_get_output(struct meson_pinctrl *pc,

				    unsigned int pin)

{

	int ret = meson_pinconf_get_gpio_bit(pc, pin, REG_DIR);

	int ret = meson_pinconf_get_gpio_bit(pc, pin, MESON_REG_DIR);



	if (ret < 0)

		return ret;
@@ -236,13 +237,13 @@ static int meson_pinconf_set_drive(struct meson_pinctrl *pc, 
				   unsigned int pin,

				   bool high)

{

	return meson_pinconf_set_gpio_bit(pc, pin, REG_OUT, high);

	return meson_pinconf_set_gpio_bit(pc, pin, MESON_REG_OUT, high);

}



static int meson_pinconf_get_drive(struct meson_pinctrl *pc,

				   unsigned int pin)

{

	return meson_pinconf_get_gpio_bit(pc, pin, REG_OUT);

	return meson_pinconf_get_gpio_bit(pc, pin, MESON_REG_OUT);

}



static int meson_pinconf_set_output_drive(struct meson_pinctrl *pc,
@@ -269,7 +270,7 @@ static int meson_pinconf_disable_bias(struct meson_pinctrl *pc, 
	if (ret)

		return ret;



	meson_calc_reg_and_bit(bank, pin, REG_PULLEN, &reg, &bit);

	meson_calc_reg_and_bit(bank, pin, MESON_REG_PULLEN, &reg, &bit);

	ret = regmap_update_bits(pc->reg_pullen, reg, BIT(bit), 0);

	if (ret)

		return ret;
@@ -288,7 +289,7 @@ static int meson_pinconf_enable_bias(struct meson_pinctrl *pc, unsigned int pin, 
	if (ret)

		return ret;



	meson_calc_reg_and_bit(bank, pin, REG_PULL, &reg, &bit);

	meson_calc_reg_and_bit(bank, pin, MESON_REG_PULL, &reg, &bit);

	if (pull_up)

		val = BIT(bit);
@@ -296,7 +297,7 @@ static int meson_pinconf_enable_bias(struct meson_pinctrl *pc, unsigned int pin, 
	if (ret)

		return ret;



	meson_calc_reg_and_bit(bank, pin, REG_PULLEN, &reg, &bit);

	meson_calc_reg_and_bit(bank, pin, MESON_REG_PULLEN, &reg, &bit);

	ret = regmap_update_bits(pc->reg_pullen, reg, BIT(bit),	BIT(bit));

	if (ret)

		return ret;
@@ -321,7 +322,7 @@ static int meson_pinconf_set_drive_strength(struct meson_pinctrl *pc, 
	if (ret)

		return ret;



	meson_calc_reg_and_bit(bank, pin, REG_DS, &reg, &bit);

	meson_calc_reg_and_bit(bank, pin, MESON_REG_DS, &reg, &bit);



	if (drive_strength_ua <= 500) {

		ds_val = MESON_PINCONF_DRV_500UA;
@@ -407,7 +408,7 @@ static int meson_pinconf_get_pull(struct meson_pinctrl *pc, unsigned int pin) 
	if (ret)

		return ret;



	meson_calc_reg_and_bit(bank, pin, REG_PULLEN, &reg, &bit);

	meson_calc_reg_and_bit(bank, pin, MESON_REG_PULLEN, &reg, &bit);



	ret = regmap_read(pc->reg_pullen, reg, &val);

	if (ret)
@@ -416,7 +417,7 @@ static int meson_pinconf_get_pull(struct meson_pinctrl *pc, unsigned int pin) 
	if (!(val & BIT(bit))) {

		conf = PIN_CONFIG_BIAS_DISABLE;

	} else {

		meson_calc_reg_and_bit(bank, pin, REG_PULL, &reg, &bit);

		meson_calc_reg_and_bit(bank, pin, MESON_REG_PULL, &reg, &bit);



		ret = regmap_read(pc->reg_pull, reg, &val);

		if (ret)
@@ -447,7 +448,7 @@ static int meson_pinconf_get_drive_strength(struct meson_pinctrl *pc, 
	if (ret)

		return ret;



	meson_calc_reg_and_bit(bank, pin, REG_DS, &reg, &bit);

	meson_calc_reg_and_bit(bank, pin, MESON_REG_DS, &reg, &bit);



	ret = regmap_read(pc->reg_ds, reg, &val);

	if (ret)
@@ -595,7 +596,7 @@ static int meson_gpio_get(struct gpio_chip *chip, unsigned gpio) 
	if (ret)

		return ret;



	meson_calc_reg_and_bit(bank, gpio, REG_IN, &reg, &bit);

	meson_calc_reg_and_bit(bank, gpio, MESON_REG_IN, &reg, &bit);

	regmap_read(pc->reg_gpio, reg, &val);



	return !!(val & BIT(bit));
@@ -662,27 +663,22 @@ static struct regmap *meson_map_resource(struct meson_pinctrl *pc, 
	return devm_regmap_init_mmio(pc->dev, base, &meson_regmap_config);

}



static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc,

				  struct device_node *node)

static int meson_pinctrl_parse_dt(struct meson_pinctrl *pc)

{

	struct device_node *np, *gpio_np = NULL;

	struct device_node *gpio_np;

	unsigned int chips;



	for_each_child_of_node(node, np) {

		if (!of_find_property(np, "gpio-controller", NULL))

			continue;

		if (gpio_np) {

			dev_err(pc->dev, "multiple gpio nodes\n");

			of_node_put(np);

	chips = gpiochip_node_count(pc->dev);

	if (!chips) {

		dev_err(pc->dev, "no gpio node found\n");

		return -EINVAL;

	}

		gpio_np = np;

	}



	if (!gpio_np) {

		dev_err(pc->dev, "no gpio node found\n");

	if (chips > 1) {

		dev_err(pc->dev, "multiple gpio nodes\n");

		return -EINVAL;

	}



	gpio_np = to_of_node(gpiochip_node_get_first(pc->dev));

	pc->of_node = gpio_np;



	pc->reg_mux = meson_map_resource(pc, gpio_np, "mux");
@@ -751,7 +747,7 @@ int meson_pinctrl_probe(struct platform_device *pdev) 
	pc->dev = dev;

	pc->data = (struct meson_pinctrl_data *) of_device_get_match_data(dev);



	ret = meson_pinctrl_parse_dt(pc, dev->of_node);

	ret = meson_pinctrl_parse_dt(pc);

	if (ret)

		return ret;

drivers/pinctrl/meson/pinctrl-meson.h

+14 −14
Original line number Diff line number Diff line
@@ -63,13 +63,13 @@ struct meson_reg_desc { 
 * enum meson_reg_type - type of registers encoded in @meson_reg_desc

 */

enum meson_reg_type {

	REG_PULLEN,

	REG_PULL,

	REG_DIR,

	REG_OUT,

	REG_IN,

	REG_DS,

	NUM_REG,

	MESON_REG_PULLEN,

	MESON_REG_PULL,

	MESON_REG_DIR,

	MESON_REG_OUT,

	MESON_REG_IN,

	MESON_REG_DS,

	MESON_NUM_REG,

};



/**
@@ -102,7 +102,7 @@ struct meson_bank { 
	unsigned int last;

	int irq_first;

	int irq_last;

	struct meson_reg_desc regs[NUM_REG];

	struct meson_reg_desc regs[MESON_NUM_REG];

};



struct meson_pinctrl_data {
@@ -150,12 +150,12 @@ struct meson_pinctrl { 
		.irq_first	= fi,					\

		.irq_last	= li,					\

		.regs = {						\

			[REG_PULLEN]	= { per, peb },			\

			[REG_PULL]	= { pr, pb },			\

			[REG_DIR]	= { dr, db },			\

			[REG_OUT]	= { or, ob },			\

			[REG_IN]	= { ir, ib },			\

			[REG_DS]	= { dsr, dsb },			\

			[MESON_REG_PULLEN]	= { per, peb },		\

			[MESON_REG_PULL]	= { pr, pb },		\

			[MESON_REG_DIR]		= { dr, db },		\

			[MESON_REG_OUT]		= { or, ob },		\

			[MESON_REG_IN]		= { ir, ib },		\

			[MESON_REG_DS]		= { dsr, dsb },		\

		},							\

	 }

drivers/pinctrl/mvebu/pinctrl-armada-37xx.c

+10 −24
Original line number Diff line number Diff line
@@ -21,6 +21,7 @@ 
#include <linux/pinctrl/pinctrl.h>

#include <linux/pinctrl/pinmux.h>

#include <linux/platform_device.h>

#include <linux/property.h>

#include <linux/regmap.h>

#include <linux/slab.h>

#include <linux/string_helpers.h>
@@ -726,23 +727,13 @@ static int armada_37xx_irqchip_register(struct platform_device *pdev, 
	struct gpio_chip *gc = &info->gpio_chip;

	struct irq_chip *irqchip = &info->irq_chip;

	struct gpio_irq_chip *girq = &gc->irq;

	struct device_node *np = to_of_node(gc->fwnode);

	struct device *dev = &pdev->dev;

	struct device_node *np;

	int ret = -ENODEV, i, nr_irq_parent;

	unsigned int i, nr_irq_parent;



	/* Check if we have at least one gpio-controller child node */

	for_each_child_of_node(dev->of_node, np) {

		if (of_property_read_bool(np, "gpio-controller")) {

			ret = 0;

			break;

		}

	}

	if (ret)

		return dev_err_probe(dev, ret, "no gpio-controller child node\n");



	nr_irq_parent = of_irq_count(np);

	spin_lock_init(&info->irq_lock);



	nr_irq_parent = of_irq_count(np);

	if (!nr_irq_parent) {

		dev_err(dev, "invalid or no IRQ\n");

		return 0;
@@ -787,18 +778,13 @@ static int armada_37xx_gpiochip_register(struct platform_device *pdev, 
					struct armada_37xx_pinctrl *info)

{

	struct device *dev = &pdev->dev;

	struct device_node *np;

	struct fwnode_handle *fwnode;

	struct gpio_chip *gc;

	int ret = -ENODEV;

	int ret;



	for_each_child_of_node(dev->of_node, np) {

		if (of_find_property(np, "gpio-controller", NULL)) {

			ret = 0;

			break;

		}

	}

	if (ret)

		return ret;

	fwnode = gpiochip_node_get_first(dev);

	if (!fwnode)

		return -ENODEV;



	info->gpio_chip = armada_37xx_gpiolib_chip;
@@ -806,7 +792,7 @@ static int armada_37xx_gpiochip_register(struct platform_device *pdev, 
	gc->ngpio = info->data->nr_pins;

	gc->parent = dev;

	gc->base = -1;

	gc->of_node = np;

	gc->fwnode = fwnode;

	gc->label = info->data->name;



	ret = armada_37xx_irqchip_register(pdev, info);