Commit c853be22 authored by Jinrong Liang's avatar Jinrong Liang Committed by Sean Christopherson
Browse files

KVM: selftests: Drop the return of remove_event() 



None of the callers consume remove_event(), and it incorrectly implies
that the incoming filter isn't modified. Drop the return.

Suggested-by: default avatarSean Christopherson <seanjc@google.com>
Signed-off-by: default avatarJinrong Liang <cloudliang@tencent.com>
Link: https://lore.kernel.org/r/20230810090945.16053-3-cloudliang@tencent.com


Signed-off-by: default avatarSean Christopherson <seanjc@google.com>
parent cf6d80c0

tools/testing/selftests/kvm/x86_64/pmu_event_filter_test.c

+1 −3
Original line number Diff line number Diff line
@@ -265,8 +265,7 @@ static struct kvm_pmu_event_filter *event_filter(uint32_t action) 
 * Remove the first occurrence of 'event' (if any) from the filter's

 * event list.

 */

static struct kvm_pmu_event_filter *remove_event(struct kvm_pmu_event_filter *f,

						 uint64_t event)

static void remove_event(struct kvm_pmu_event_filter *f, uint64_t event)

{

	bool found = false;

	int i;
@@ -279,7 +278,6 @@ static struct kvm_pmu_event_filter *remove_event(struct kvm_pmu_event_filter *f, 
	}

	if (found)

		f->nevents--;

	return f;

}



#define ASSERT_PMC_COUNTING_INSTRUCTIONS()						\