Commit c841ecd8 authored by Dan Williams's avatar Dan Williams
Browse files

cxl/hdm: Add more HDM decoder debug messages at startup 



A recent debug session yielded a couple debug messages that were useful
for determining the reason why the driver was or was not falling back
to CXL range register emulation, and for identifying decoder setting
enumeration problems.

Reviewed-by: default avatarDave Jiang <dave.jiang@intel.com>
Reviewed-by: default avatarAlison Schofield <alison.schofield@intel.com>
Link: https://lore.kernel.org/r/168149845668.792294.11814353796371419167.stgit@dwillia2-xfh.jf.intel.com


Signed-off-by: default avatarDan Williams <dan.j.williams@intel.com>
parent 7bba261e

drivers/cxl/core/hdm.c

+12 −0
Original line number Diff line number Diff line
@@ -130,6 +130,14 @@ static bool should_emulate_decoders(struct cxl_endpoint_dvsec_info *info) 
	 */

	for (i = 0; i < cxlhdm->decoder_count; i++) {

		ctrl = readl(hdm + CXL_HDM_DECODER0_CTRL_OFFSET(i));

		dev_dbg(&info->port->dev,

			"decoder%d.%d: committed: %ld base: %#x_%.8x size: %#x_%.8x\n",

			info->port->id, i,

			FIELD_GET(CXL_HDM_DECODER0_CTRL_COMMITTED, ctrl),

			readl(hdm + CXL_HDM_DECODER0_BASE_HIGH_OFFSET(i)),

			readl(hdm + CXL_HDM_DECODER0_BASE_LOW_OFFSET(i)),

			readl(hdm + CXL_HDM_DECODER0_SIZE_HIGH_OFFSET(i)),

			readl(hdm + CXL_HDM_DECODER0_SIZE_LOW_OFFSET(i)));

		if (FIELD_GET(CXL_HDM_DECODER0_CTRL_COMMITTED, ctrl))

			return false;

	}
@@ -868,6 +876,10 @@ static int init_hdm_decoder(struct cxl_port *port, struct cxl_decoder *cxld, 
	if (rc)

		return rc;



	dev_dbg(&port->dev, "decoder%d.%d: range: %#llx-%#llx iw: %d ig: %d\n",

		port->id, cxld->id, cxld->hpa_range.start, cxld->hpa_range.end,

		cxld->interleave_ways, cxld->interleave_granularity);



	if (!info) {

		lo = readl(hdm + CXL_HDM_DECODER0_TL_LOW(which));

		hi = readl(hdm + CXL_HDM_DECODER0_TL_HIGH(which));