Commit c838f1a7 authored by David Howells's avatar David Howells Committed by David S. Miller
Browse files

rxrpc: Fix switched parameters in peer tracing 



Fix the switched parameters on rxrpc_alloc_peer() and rxrpc_get_peer().
The ref argument and the why argument got mixed.

Fixes: 47c810a7 ("rxrpc: trace: Don't use __builtin_return_address for rxrpc_peer tracing")
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
cc: Marc Dionne <marc.dionne@auristor.com>
cc: linux-afs@lists.infradead.org
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 608aecd1

include/trace/events/rxrpc.h

+1 −1
Original line number Diff line number Diff line
@@ -471,7 +471,7 @@ TRACE_EVENT(rxrpc_peer, 
	    TP_STRUCT__entry(

		    __field(unsigned int,	peer		)

		    __field(int,		ref		)

		    __field(int,		why		)

		    __field(enum rxrpc_peer_trace, why		)

			     ),



	    TP_fast_assign(

net/rxrpc/peer_object.c

+2 −2
Original line number Diff line number Diff line
@@ -226,7 +226,7 @@ struct rxrpc_peer *rxrpc_alloc_peer(struct rxrpc_local *local, gfp_t gfp, 
		rxrpc_peer_init_rtt(peer);



		peer->cong_ssthresh = RXRPC_TX_MAX_WINDOW;

		trace_rxrpc_peer(peer->debug_id, why, 1);

		trace_rxrpc_peer(peer->debug_id, 1, why);

	}



	_leave(" = %p", peer);
@@ -382,7 +382,7 @@ struct rxrpc_peer *rxrpc_get_peer(struct rxrpc_peer *peer, enum rxrpc_peer_trace 
	int r;



	__refcount_inc(&peer->ref, &r);

	trace_rxrpc_peer(peer->debug_id, why, r + 1);

	trace_rxrpc_peer(peer->debug_id, r + 1, why);

	return peer;

}