Commit c838de1a authored by Bart Van Assche's avatar Bart Van Assche Committed by Jason Gunthorpe
Browse files

RDMA/srp: Add more structure size checks 

Before modifying how the __packed attribute is used, add compile time
size checks for the structures that will be modified.

Link: https://lore.kernel.org/r/20210524041211.9480-3-bvanassche@acm.org


Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Cc: Nicolas Morey-Chaisemartin <nmoreychaisemartin@suse.com>
Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 17bb6b6b

drivers/infiniband/ulp/srp/ib_srp.c

+4 −1
Original line number Diff line number Diff line
@@ -4078,10 +4078,13 @@ static int __init srp_init_module(void) 
{

	int ret;



	BUILD_BUG_ON(sizeof(struct srp_aer_req) != 36);

	BUILD_BUG_ON(sizeof(struct srp_cmd) != 48);

	BUILD_BUG_ON(sizeof(struct srp_imm_buf) != 4);

	BUILD_BUG_ON(sizeof(struct srp_indirect_buf) != 20);

	BUILD_BUG_ON(sizeof(struct srp_login_req) != 64);

	BUILD_BUG_ON(sizeof(struct srp_login_req_rdma) != 56);

	BUILD_BUG_ON(sizeof(struct srp_cmd) != 48);

	BUILD_BUG_ON(sizeof(struct srp_rsp) != 36);



	if (srp_sg_tablesize) {

		pr_warn("srp_sg_tablesize is deprecated, please use cmd_sg_entries\n");