Commit c833ac1a authored by Oded Gabbay's avatar Oded Gabbay
Browse files

habanalabs/gaudi2: free event irq if init fails 



In case initialization fails after event irq was requested, we need to
release that irq.

Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 76925f55

drivers/misc/habanalabs/gaudi2/gaudi2.c

+5 −1
Original line number Diff line number Diff line
@@ -3581,7 +3581,7 @@ static int gaudi2_enable_msix(struct hl_device *hdev) 
	rc = gaudi2_dec_enable_msix(hdev);

	if (rc) {

		dev_err(hdev->dev, "Failed to enable decoder IRQ");

		goto free_completion_irq;

		goto free_event_irq;

	}



	for (i = GAUDI2_IRQ_NUM_USER_FIRST, j = prop->user_dec_intr_count, user_irq_init_cnt = 0;
@@ -3612,6 +3612,10 @@ static int gaudi2_enable_msix(struct hl_device *hdev) 


	gaudi2_dec_disable_msix(hdev, GAUDI2_IRQ_NUM_SHARED_DEC1_ABNRM + 1);



free_event_irq:

	irq = pci_irq_vector(hdev->pdev, GAUDI2_IRQ_NUM_EVENT_QUEUE);

	free_irq(irq, cq);



free_completion_irq:

	irq = pci_irq_vector(hdev->pdev, GAUDI2_IRQ_NUM_COMPLETION);

	free_irq(irq, cq);