Commit c82d5bc7 authored by Pavel Begunkov's avatar Pavel Begunkov Committed by Jens Axboe
Browse files

io_uring: don't fail submit with overflow backlog 



Don't fail submission attempts if there are CQEs in the overflow
backlog, but give away the decision making to the userspace. It
might be very inconvenient to the userspace, especially if
submission and completion are done by different threads.

We can remove it because of recent changes, where requests
are now not locked by the backlog, backlog entries are allocated
separately, so they take less space and cgroup accounted.

Signed-off-by: default avatarPavel Begunkov <asml.silence@gmail.com>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent a7be7c23

fs/io_uring.c

+0 −6
Original line number Diff line number Diff line
@@ -6664,12 +6664,6 @@ static int io_submit_sqes(struct io_ring_ctx *ctx, unsigned int nr) 
{

	int submitted = 0;



	/* if we have a backlog and couldn't flush it all, return BUSY */

	if (test_bit(0, &ctx->sq_check_overflow)) {

		if (!__io_cqring_overflow_flush(ctx, false))

			return -EBUSY;

	}



	/* make sure SQ entry isn't read before tail */

	nr = min3(nr, ctx->sq_entries, io_sqring_entries(ctx));