Commit c804b83d authored by Simon Ser's avatar Simon Ser
Browse files

drm/atomic: log drm_atomic_replace_property_blob_from_id() errors 



Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
Reviewed-by: default avatarDaniel Vetter <daniel.vetter@ffwll.ch>
Cc: Jani Nikula <jani.nikula@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221019143736.267324-1-contact@emersion.fr
parent 1627f650

drivers/gpu/drm/drm_atomic_uapi.c

+10 −1
Original line number Diff line number Diff line
@@ -374,16 +374,25 @@ drm_atomic_replace_property_blob_from_id(struct drm_device *dev, 


	if (blob_id != 0) {

		new_blob = drm_property_lookup_blob(dev, blob_id);

		if (new_blob == NULL)

		if (new_blob == NULL) {

			drm_dbg_atomic(dev,

				       "cannot find blob ID %llu\n", blob_id);

			return -EINVAL;

		}



		if (expected_size > 0 &&

		    new_blob->length != expected_size) {

			drm_dbg_atomic(dev,

				       "[BLOB:%d] length %zu different from expected %zu\n",

				       new_blob->base.id, new_blob->length, expected_size);

			drm_property_blob_put(new_blob);

			return -EINVAL;

		}

		if (expected_elem_size > 0 &&

		    new_blob->length % expected_elem_size != 0) {

			drm_dbg_atomic(dev,

				       "[BLOB:%d] length %zu not divisible by element size %zu\n",

				       new_blob->base.id, new_blob->length, expected_elem_size);

			drm_property_blob_put(new_blob);

			return -EINVAL;

		}