Unverified Commit c7fd95cd authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Krzysztof Wilczyński
Browse files

PCI: tegra: Convert to platform remove callback returning void 

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Link: https://lore.kernel.org/linux-pci/20230321193208.366561-15-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
parent 2998efcd

drivers/pci/controller/pci-tegra.c

+2 −4
Original line number Diff line number Diff line
@@ -2680,7 +2680,7 @@ static int tegra_pcie_probe(struct platform_device *pdev) 
	return err;

}



static int tegra_pcie_remove(struct platform_device *pdev)

static void tegra_pcie_remove(struct platform_device *pdev)

{

	struct tegra_pcie *pcie = platform_get_drvdata(pdev);

	struct pci_host_bridge *host = pci_host_bridge_from_priv(pcie);
@@ -2701,8 +2701,6 @@ static int tegra_pcie_remove(struct platform_device *pdev) 


	list_for_each_entry_safe(port, tmp, &pcie->ports, list)

		tegra_pcie_port_free(port);



	return 0;

}



static int tegra_pcie_pm_suspend(struct device *dev)
@@ -2808,6 +2806,6 @@ static struct platform_driver tegra_pcie_driver = { 
		.pm = &tegra_pcie_pm_ops,

	},

	.probe = tegra_pcie_probe,

	.remove = tegra_pcie_remove,

	.remove_new = tegra_pcie_remove,

};

module_platform_driver(tegra_pcie_driver);