Commit c7f90201 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: usb-audio: Don't set altsetting before initializing sample rate 



Setting the active altsetting at changing sample rate seems
unrecommended.  The host should deselect the altsetting at first
before that, then select it again.

Tested-by: default avatarKeith Milner <kamilner@superlative.org>
Tested-by: default avatarDylan Robinson <dylan_robinson@motu.com>
Link: https://lore.kernel.org/r/20201123085347.19667-18-tiwai@suse.de


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent e42a09bc

sound/usb/stream.c

+2 −1
Original line number Diff line number Diff line
@@ -1223,9 +1223,10 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip, 
		}



		/* try to set the interface... */

		usb_set_interface(chip->dev, iface_no, altno);

		usb_set_interface(chip->dev, iface_no, 0);

		snd_usb_init_pitch(chip, iface_no, alts, fp);

		snd_usb_init_sample_rate(chip, iface_no, alts, fp, fp->rate_max);

		usb_set_interface(chip->dev, iface_no, altno);

	}

	return 0;

}