Commit c7d7b9ac authored by Tom Rix's avatar Tom Rix Committed by Oded Gabbay
Browse files

habanalabs: remove redundant memset 



From reviewing the code, the line
  memset(kdata, 0, usize);
is not needed because kdata is either zeroed by
  kdata = kzalloc(asize, GFP_KERNEL);
when allocated at runtime or by
  char stack_kdata[128] = {0};
at compile time.

Signed-off-by: default avatarTom Rix <trix@redhat.com>
Reviewed-by: default avatarOded Gabbay <ogabbay@kernel.org>
Signed-off-by: default avatarOded Gabbay <ogabbay@kernel.org>
parent 78baccbd

drivers/accel/habanalabs/common/habanalabs_ioctl.c

+0 −2
Original line number Diff line number Diff line
@@ -1123,8 +1123,6 @@ static long _hl_ioctl(struct file *filep, unsigned int cmd, unsigned long arg, 
			retcode = -EFAULT;

			goto out_err;

		}

	} else if (cmd & IOC_OUT) {

		memset(kdata, 0, usize);

	}



	retcode = func(hpriv, kdata);