Commit c79a7070 authored by Johan Hovold's avatar Johan Hovold Committed by David S. Miller
Browse files

net: cdc-phonet: fix data-interface release on probe failure 



Set the disconnected flag before releasing the data interface in case
netdev registration fails to avoid having the disconnect callback try to
deregister the never registered netdev (and trigger a WARN_ON()).

Fixes: 87cf6560 ("USB host CDC Phonet network interface driver")
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 84f4aced

drivers/net/usb/cdc-phonet.c

+2 −0
Original line number Diff line number Diff line
@@ -387,6 +387,8 @@ static int usbpn_probe(struct usb_interface *intf, const struct usb_device_id *i 


	err = register_netdev(dev);

	if (err) {

		/* Set disconnected flag so that disconnect() returns early. */

		pnd->disconnected = 1;

		usb_driver_release_interface(&usbpn_driver, data_intf);

		goto out;

	}