Commit c79515e4 authored by Hayes Wang's avatar Hayes Wang Committed by Jakub Kicinski
Browse files

r8152: check if the pointer of the function exists 



Return error code if autosuspend_en, eee_get, or eee_set don't exist.

Signed-off-by: default avatarHayes Wang <hayeswang@realtek.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 7a0ae61a

drivers/net/usb/r8152.c

+13 −0
Original line number Diff line number Diff line
@@ -5757,6 +5757,9 @@ static int rtl8152_runtime_suspend(struct r8152 *tp) 
	struct net_device *netdev = tp->netdev;

	int ret = 0;



	if (!tp->rtl_ops.autosuspend_en)

		return -EBUSY;



	set_bit(SELECTIVE_SUSPEND, &tp->flags);

	smp_mb__after_atomic();
@@ -6156,6 +6159,11 @@ rtl_ethtool_get_eee(struct net_device *net, struct ethtool_eee *edata) 
	struct r8152 *tp = netdev_priv(net);

	int ret;



	if (!tp->rtl_ops.eee_get) {

		ret = -EOPNOTSUPP;

		goto out;

	}



	ret = usb_autopm_get_interface(tp->intf);

	if (ret < 0)

		goto out;
@@ -6178,6 +6186,11 @@ rtl_ethtool_set_eee(struct net_device *net, struct ethtool_eee *edata) 
	struct r8152 *tp = netdev_priv(net);

	int ret;



	if (!tp->rtl_ops.eee_set) {

		ret = -EOPNOTSUPP;

		goto out;

	}



	ret = usb_autopm_get_interface(tp->intf);

	if (ret < 0)

		goto out;