Commit c78be80d authored by Martin K. Petersen's avatar Martin K. Petersen
Browse files

scsi: scsi_debug: Remove dump_sector() 

The function used to dump sectors containing protection information errors
was useful during initial development over a decade ago.  However,
dump_sector() substantially slows down the system during testing due to
writing an entire sector's worth of data to syslog on every error.

We now log plenty of information about the nature of detected protection
information errors throughout the stack. Dumping the entire contents of an
offending sector is no longer needed.

Link: https://lore.kernel.org/r/20210609033929.3815-9-martin.petersen@oracle.com


Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Reviewed-by: default avatarDouglas Gilbert <dgilbert@interlog.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
Message-Id: <20210609033929.3815-9-martin.petersen@oracle.com>
parent 73e61d5c

drivers/scsi/scsi_debug.c

+1 −25
Original line number Diff line number Diff line
@@ -3232,28 +3232,6 @@ static int resp_read_dt0(struct scsi_cmnd *scp, struct sdebug_dev_info *devip) 
	return 0;

}



static void dump_sector(unsigned char *buf, int len)

{

	int i, j, n;



	pr_err(">>> Sector Dump <<<\n");

	for (i = 0 ; i < len ; i += 16) {

		char b[128];



		for (j = 0, n = 0; j < 16; j++) {

			unsigned char c = buf[i+j];



			if (c >= 0x20 && c < 0x7e)

				n += scnprintf(b + n, sizeof(b) - n,

					       " %c ", buf[i+j]);

			else

				n += scnprintf(b + n, sizeof(b) - n,

					       "%02x ", buf[i+j]);

		}

		pr_err("%04d: %s\n", i, b);

	}

}



static int prot_verify_write(struct scsi_cmnd *SCpnt, sector_t start_sec,

			     unsigned int sectors, u32 ei_lba)

{
@@ -3300,10 +3278,8 @@ static int prot_verify_write(struct scsi_cmnd *SCpnt, sector_t start_sec, 
			daddr = diter.addr + dpage_offset;



			ret = dif_verify(sdt, daddr, sector, ei_lba);

			if (ret) {

				dump_sector(daddr, sdebug_sector_size);

			if (ret)

				goto out;

			}



			sector++;

			ei_lba++;