Commit c75f2feb authored by Sahitya Tummala's avatar Sahitya Tummala Committed by Jaegeuk Kim
Browse files

f2fs: do not update REQ_TIME in case of error conditions 



The REQ_TIME should be updated only in case of success cases
as followed at all other places in the file system.

Signed-off-by: default avatarSahitya Tummala <stummala@codeaurora.org>
Reviewed-by: default avatarChao Yu <yuchao0@huawei.com>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
parent 3b30eb19

fs/f2fs/dir.c

+1 −1
Original line number Diff line number Diff line
@@ -655,9 +655,9 @@ int f2fs_do_tmpfile(struct inode *inode, struct inode *dir) 
	f2fs_put_page(page, 1);



	clear_inode_flag(inode, FI_NEW_INODE);

	f2fs_update_time(F2FS_I_SB(inode), REQ_TIME);

fail:

	up_write(&F2FS_I(inode)->i_sem);

	f2fs_update_time(F2FS_I_SB(inode), REQ_TIME);

	return err;

}

fs/f2fs/file.c

+1 −1
Original line number Diff line number Diff line
@@ -106,6 +106,7 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) 
		SetPageUptodate(page);



	f2fs_update_iostat(sbi, APP_MAPPED_IO, F2FS_BLKSIZE);

	f2fs_update_time(sbi, REQ_TIME);



	trace_f2fs_vm_page_mkwrite(page, DATA);

out_sem:
@@ -114,7 +115,6 @@ static vm_fault_t f2fs_vm_page_mkwrite(struct vm_fault *vmf) 
	f2fs_balance_fs(sbi, dn.node_changed);



	sb_end_pagefault(inode->i_sb);

	f2fs_update_time(sbi, REQ_TIME);

err:

	return block_page_mkwrite_return(err);

}