Commit c749301e authored by Damien Le Moal's avatar Damien Le Moal Committed by Martin K. Petersen
Browse files

scsi: sd: Fix sd_do_mode_sense() buffer length handling 

For devices that explicitly asked for MODE SENSE(10) use, make sure that
scsi_mode_sense() is called with a buffer of at least 8 bytes so that the
sense header fits.

Link: https://lore.kernel.org/r/20210820070255.682775-4-damien.lemoal@wdc.com


Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent a7d6840b

drivers/scsi/sd.c

+7 −0
Original line number Diff line number Diff line
@@ -2604,6 +2604,13 @@ sd_do_mode_sense(struct scsi_disk *sdkp, int dbd, int modepage, 
		 unsigned char *buffer, int len, struct scsi_mode_data *data,

		 struct scsi_sense_hdr *sshdr)

{

	/*

	 * If we must use MODE SENSE(10), make sure that the buffer length

	 * is at least 8 bytes so that the mode sense header fits.

	 */

	if (sdkp->device->use_10_for_ms && len < 8)

		len = 8;



	return scsi_mode_sense(sdkp->device, dbd, modepage, buffer, len,

			       SD_TIMEOUT, sdkp->max_retries, data,

			       sshdr);