Commit c72e3171 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Bjorn Andersson
Browse files

soc: qcom: ramp_controller: Improve error message for failure in .remove() 



When a platform_driver's .remove() callback returns an error, the driver
core emits

	remove callback returned a non-zero value. This will be ignored.

. Replace this by a more specific error message. Then convert to
.remove_new() which is equivalent to returning zero unconditionally in
.remove(). See commit 5c5a7680 ("platform: Provide a remove callback
that returns no value") for its rationale.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarBjorn Andersson <andersson@kernel.org>
Link: https://lore.kernel.org/r/20230415201848.3779001-1-u.kleine-koenig@pengutronix.de
parent 1252ea65

drivers/soc/qcom/ramp_controller.c

+7 −4
Original line number Diff line number Diff line
@@ -308,12 +308,15 @@ static int qcom_ramp_controller_probe(struct platform_device *pdev) 
	return qcom_ramp_controller_start(qrc);

}



static int qcom_ramp_controller_remove(struct platform_device *pdev)

static void qcom_ramp_controller_remove(struct platform_device *pdev)

{

	struct qcom_ramp_controller *qrc = platform_get_drvdata(pdev);

	int ret;



	return rc_write_cfg(qrc, qrc->desc->cfg_ramp_dis,

	ret = rc_write_cfg(qrc, qrc->desc->cfg_ramp_dis,

			   RC_DCVS_CFG_SID, qrc->desc->num_ramp_dis);

	if (ret)

		dev_err(&pdev->dev, "Failed to send disable sequence\n");

}



static const struct of_device_id qcom_ramp_controller_match_table[] = {
@@ -329,7 +332,7 @@ static struct platform_driver qcom_ramp_controller_driver = { 
		.suppress_bind_attrs = true,

	},

	.probe  = qcom_ramp_controller_probe,

	.remove = qcom_ramp_controller_remove,

	.remove_new = qcom_ramp_controller_remove,

};



static int __init qcom_ramp_controller_init(void)