Commit c724f776 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

staging: rtl8712: fix interface sanity check 



Make sure to use the current alternate setting when verifying the
interface descriptors to avoid binding to an invalid interface.

Failing to do so could cause the driver to misbehave or trigger a WARN()
in usb_submit_urb() that kernels with panic_on_warn set would choke on.

Fixes: 2865d42c ("staging: r8712u: Add the new driver to the mainline kernel")
Cc: stable <stable@vger.kernel.org>     # 2.6.37
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191210114751.5119-3-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 74ca3411

drivers/staging/rtl8712/usb_intf.c

+1 −1
Original line number Diff line number Diff line
@@ -247,7 +247,7 @@ static uint r8712_usb_dvobj_init(struct _adapter *padapter) 


	pdvobjpriv->padapter = padapter;

	padapter->eeprom_address_size = 6;

	phost_iface = &pintf->altsetting[0];

	phost_iface = pintf->cur_altsetting;

	piface_desc = &phost_iface->desc;

	pdvobjpriv->nr_endpoint = piface_desc->bNumEndpoints;

	if (pusbd->speed == USB_SPEED_HIGH) {