Commit c6fe6be6 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Takashi Iwai
Browse files

ALSA: hda: ext: remove always-true conditions on host and link release 



By construction a host and link DMA are always decoupled. This
decoupling happens in the assign() phase. There's no point in checking
if the two parts are decoupled, this is by-design always-true.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Link: https://lore.kernel.org/r/20220919121041.43463-9-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent ac3467ad

sound/hda/ext/hdac_ext_stream.c

+4 −2
Original line number Diff line number Diff line
@@ -382,7 +382,8 @@ void snd_hdac_ext_stream_release(struct hdac_ext_stream *hext_stream, int type) 


	case HDAC_EXT_STREAM_TYPE_HOST:

		spin_lock_irq(&bus->reg_lock);

		if (hext_stream->decoupled && !hext_stream->link_locked)

		/* couple link only if not in use */

		if (!hext_stream->link_locked)

			snd_hdac_ext_stream_decouple_locked(bus, hext_stream, false);

		snd_hdac_stream_release_locked(&hext_stream->hstream);

		spin_unlock_irq(&bus->reg_lock);
@@ -390,7 +391,8 @@ void snd_hdac_ext_stream_release(struct hdac_ext_stream *hext_stream, int type) 


	case HDAC_EXT_STREAM_TYPE_LINK:

		spin_lock_irq(&bus->reg_lock);

		if (hext_stream->decoupled && !hext_stream->hstream.opened)

		/* couple host only if not in use */

		if (!hext_stream->hstream.opened)

			snd_hdac_ext_stream_decouple_locked(bus, hext_stream, false);

		hext_stream->link_locked = 0;

		hext_stream->link_substream = NULL;