Commit c6eee9df authored by Masahiro Yamada's avatar Masahiro Yamada Committed by Luis Chamberlain
Browse files

module: do not pass opaque pointer for symbol search 



There is no need to use an opaque pointer for check_exported_symbol()
or find_exported_symbol_in_section.

Pass (struct find_symbol_arg *) explicitly.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
Signed-off-by: default avatarLuis Chamberlain <mcgrof@kernel.org>
parent 8eac910a

kernel/module/main.c

+4 −7
Original line number Diff line number Diff line
@@ -244,11 +244,9 @@ static __maybe_unused void *any_section_objs(const struct load_info *info, 
#endif



static bool check_exported_symbol(const struct symsearch *syms,

				  struct module *owner,

				  unsigned int symnum, void *data)

				  struct module *owner, unsigned int symnum,

				  struct find_symbol_arg *fsa)

{

	struct find_symbol_arg *fsa = data;



	if (!fsa->gplok && syms->license == GPL_ONLY)

		return false;

	fsa->owner = owner;
@@ -285,16 +283,15 @@ int cmp_name(const void *name, const void *sym) 


static bool find_exported_symbol_in_section(const struct symsearch *syms,

					    struct module *owner,

					    void *data)

					    struct find_symbol_arg *fsa)

{

	struct find_symbol_arg *fsa = data;

	struct kernel_symbol *sym;



	sym = bsearch(fsa->name, syms->start, syms->stop - syms->start,

			sizeof(struct kernel_symbol), cmp_name);



	if (sym != NULL && check_exported_symbol(syms, owner,

						 sym - syms->start, data))

						 sym - syms->start, fsa))

		return true;



	return false;