Commit c6e78718 authored by luo penghao's avatar luo penghao Committed by Steffen Klassert
Browse files

ipv6/esp6: Remove structure variables and alignment statements 



The definition of this variable is just to find the length of the
structure after aligning the structure. The PTR alignment function
is to optimize the size of the structure. In fact, it doesn't seem
to be of much use, because both members of the structure are of
type u32.
So I think that the definition of the variable and the
corresponding alignment can be deleted, the value of extralen can
be directly passed in the size of the structure.

The clang_analyzer complains as follows:

net/ipv6/esp6.c:117:27 warning:

Value stored to 'extra' during its initialization is never read

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarluo penghao <luo.penghao@zte.com.cn>
Signed-off-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
parent bb8cecf8

net/ipv6/esp6.c

+1 −2
Original line number Diff line number Diff line
@@ -114,7 +114,6 @@ static inline struct scatterlist *esp_req_sg(struct crypto_aead *aead, 


static void esp_ssg_unref(struct xfrm_state *x, void *tmp)

{

	struct esp_output_extra *extra = esp_tmp_extra(tmp);

	struct crypto_aead *aead = x->data;

	int extralen = 0;

	u8 *iv;
@@ -122,7 +121,7 @@ static void esp_ssg_unref(struct xfrm_state *x, void *tmp) 
	struct scatterlist *sg;



	if (x->props.flags & XFRM_STATE_ESN)

		extralen += sizeof(*extra);

		extralen += sizeof(struct esp_output_extra);



	iv = esp_tmp_iv(aead, tmp, extralen);

	req = esp_tmp_req(aead, iv);