Commit c6cf0b60 authored by Zhengchao Shao's avatar Zhengchao Shao Committed by Saeed Mahameed
Browse files

net/mlx5: fix potential memory leak in mlx5e_init_rep_rx 



The memory pointed to by the priv->rx_res pointer is not freed in the error
path of mlx5e_init_rep_rx, which can lead to a memory leak. Fix by freeing
the memory in the error path, thereby making the error path identical to
mlx5e_cleanup_rep_rx().

Fixes: af8bbf73 ("net/mlx5e: Convert mlx5e_flow_steering member of mlx5e_priv to pointer")
Signed-off-by: default avatarZhengchao Shao <shaozhengchao@huawei.com>
Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent 5dd77585

drivers/net/ethernet/mellanox/mlx5/core/en_rep.c

+2 −1
Original line number Original line Diff line number Diff line
@@ -1012,7 +1012,7 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv) 
	err = mlx5e_open_drop_rq(priv, &priv->drop_rq);

	err = mlx5e_open_drop_rq(priv, &priv->drop_rq);

	if (err) {

	if (err) {

		mlx5_core_err(mdev, "open drop rq failed, %d\n", err);

		mlx5_core_err(mdev, "open drop rq failed, %d\n", err);

		return err;

		goto err_rx_res_free;

	}

	}





	err = mlx5e_rx_res_init(priv->rx_res, priv->mdev, 0,

	err = mlx5e_rx_res_init(priv->rx_res, priv->mdev, 0,
@@ -1046,6 +1046,7 @@ static int mlx5e_init_rep_rx(struct mlx5e_priv *priv) 
	mlx5e_rx_res_destroy(priv->rx_res);

	mlx5e_rx_res_destroy(priv->rx_res);

err_close_drop_rq:

err_close_drop_rq:

	mlx5e_close_drop_rq(&priv->drop_rq);

	mlx5e_close_drop_rq(&priv->drop_rq);

err_rx_res_free:

	mlx5e_rx_res_free(priv->rx_res);

	mlx5e_rx_res_free(priv->rx_res);

	priv->rx_res = NULL;

	priv->rx_res = NULL;

err_free_fs:

err_free_fs: