Commit c6b9d566 authored by Johannes Berg's avatar Johannes Berg
Browse files

wifi: iwlwifi: remove disable_dummy_notification 



This struct member is read-only, so can never change away
from the default value of zero. Remove the code that's in
an if on the value, since it's effectively dead code.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarGregory Greenman <gregory.greenman@intel.com>
Link: https://lore.kernel.org/r/20230620125813.e7c96d0aa805.I5b158ce15e48393d2896c0bff9f644d983f0e92d@changeid


Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
parent 3a9690d0

drivers/net/wireless/intel/iwlwifi/iwl-config.h

+0 −1
Original line number Diff line number Diff line
@@ -388,7 +388,6 @@ struct iwl_cfg { 
	    high_temp:1,

	    mac_addr_from_csr:10,

	    lp_xtal_workaround:1,

	    disable_dummy_notification:1,

	    apmg_not_supported:1,

	    vht_mu_mimo_supported:1,

	    cdb:1,

drivers/net/wireless/intel/iwlwifi/mvm/sf.c

+1 −4
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause

/*

 * Copyright (C) 2013-2014, 2018-2019, 2022 Intel Corporation

 * Copyright (C) 2013-2014, 2018-2019, 2022-2023 Intel Corporation

 * Copyright (C) 2013-2014 Intel Mobile Communications GmbH

 */

#include "mvm.h"
@@ -180,9 +180,6 @@ static int iwl_mvm_sf_config(struct iwl_mvm *mvm, struct ieee80211_sta *sta, 
	};

	int ret = 0;



	if (mvm->cfg->disable_dummy_notification)

		sf_cmd.state |= cpu_to_le32(SF_CFG_DUMMY_NOTIF_OFF);



	/*

	 * If an associated AP sta changed its antenna configuration, the state

	 * will remain FULL_ON but SF parameters need to be reconsidered.