Commit c6b7314d authored by Alexander Lobakin's avatar Alexander Lobakin Committed by David S. Miller
Browse files

net: qed: cleanup global structs declarations 



Fix several sparse warnings by moving structs declarations into
the corresponding header files:

drivers/net/ethernet/qlogic/qed/qed_dcbx.c:2402:32: warning:
symbol 'qed_dcbnl_ops_pass' was not declared. Should it be static?

drivers/net/ethernet/qlogic/qed/qed_ll2.c:2754:26: warning: symbol
'qed_ll2_ops_pass' was not declared. Should it be static?

drivers/net/ethernet/qlogic/qed/qed_ptp.c:449:30: warning: symbol
'qed_ptp_ops_pass' was not declared. Should it be static?

drivers/net/ethernet/qlogic/qed/qed_sriov.c:5265:29: warning:
symbol 'qed_iov_ops_pass' was not declared. Should it be static?

(some of them were declared twice in different header files)

Also make qed_hw_err_type_descr[] const while at it.

Signed-off-by: default avatarAlexander Lobakin <alobakin@marvell.com>
Signed-off-by: default avatarIgor Russkikh <irusskikh@marvell.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 0dfda108

drivers/net/ethernet/qlogic/qed/qed_dcbx.h

+2 −0
Original line number Diff line number Diff line
@@ -81,6 +81,8 @@ struct qed_dcbx_mib_meta_data { 
	u32 addr;

};



extern const struct qed_eth_dcbnl_ops qed_dcbnl_ops_pass;



#ifdef CONFIG_DCB

int qed_dcbx_get_config_params(struct qed_hwfn *, struct qed_dcbx_set *);

drivers/net/ethernet/qlogic/qed/qed_fcoe.h

+0 −5
Original line number Diff line number Diff line
@@ -45,9 +45,4 @@ static inline void qed_get_protocol_stats_fcoe(struct qed_dev *cdev, 
}

#endif /* CONFIG_QED_FCOE */



#ifdef CONFIG_QED_LL2

extern const struct qed_common_ops qed_common_ops_pass;

extern const struct qed_ll2_ops qed_ll2_ops_pass;

#endif



#endif /* _QED_FCOE_H */

drivers/net/ethernet/qlogic/qed/qed_iscsi.h

+0 −4
Original line number Diff line number Diff line
@@ -26,10 +26,6 @@ struct qed_iscsi_info { 
	iscsi_event_cb_t event_cb;

};



#ifdef CONFIG_QED_LL2

extern const struct qed_ll2_ops qed_ll2_ops_pass;

#endif



#if IS_ENABLED(CONFIG_QED_ISCSI)

int qed_iscsi_alloc(struct qed_hwfn *p_hwfn);

drivers/net/ethernet/qlogic/qed/qed_l2.c

+2 −10
Original line number Diff line number Diff line
@@ -24,6 +24,7 @@ 
#include "qed.h"

#include <linux/qed/qed_chain.h>

#include "qed_cxt.h"

#include "qed_dcbx.h"

#include "qed_dev_api.h"

#include <linux/qed/qed_eth_if.h>

#include "qed_hsi.h"
@@ -31,6 +32,7 @@ 
#include "qed_int.h"

#include "qed_l2.h"

#include "qed_mcp.h"

#include "qed_ptp.h"

#include "qed_reg_addr.h"

#include "qed_sp.h"

#include "qed_sriov.h"
@@ -2874,16 +2876,6 @@ static int qed_req_bulletin_update_mac(struct qed_dev *cdev, u8 *mac) 
	return 0;

}



#ifdef CONFIG_QED_SRIOV

extern const struct qed_iov_hv_ops qed_iov_ops_pass;

#endif



#ifdef CONFIG_DCB

extern const struct qed_eth_dcbnl_ops qed_dcbnl_ops_pass;

#endif



extern const struct qed_eth_ptp_ops qed_ptp_ops_pass;



static const struct qed_eth_ops qed_eth_ops_pass = {

	.common = &qed_common_ops_pass,

#ifdef CONFIG_QED_SRIOV

drivers/net/ethernet/qlogic/qed/qed_ll2.h

+2 −0
Original line number Diff line number Diff line
@@ -116,6 +116,8 @@ struct qed_ll2_info { 
	struct qed_ll2_cbs cbs;

};



extern const struct qed_ll2_ops qed_ll2_ops_pass;



/**

 * @brief qed_ll2_acquire_connection - allocate resources,

 *        starts rx & tx (if relevant) queues pair. Provides