Commit c69b2f46 authored by Zheyu Ma's avatar Zheyu Ma Committed by David S. Miller
Browse files

cavium: Fix return values of the probe function 



During the process of driver probing, the probe function should return < 0
for failure, otherwise, the kernel will treat value > 0 as success.

Signed-off-by: default avatarZheyu Ma <zheyuma97@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e2112100

drivers/net/ethernet/cavium/thunder/nicvf_main.c

+2 −2
Original line number Diff line number Diff line
@@ -1224,7 +1224,7 @@ static int nicvf_register_misc_interrupt(struct nicvf *nic) 
	if (ret < 0) {

		netdev_err(nic->netdev,

			   "Req for #%d msix vectors failed\n", nic->num_vec);

		return 1;

		return ret;

	}



	sprintf(nic->irq_name[irq], "%s Mbox", "NICVF");
@@ -1243,7 +1243,7 @@ static int nicvf_register_misc_interrupt(struct nicvf *nic) 
	if (!nicvf_check_pf_ready(nic)) {

		nicvf_disable_intr(nic, NICVF_INTR_MBOX, 0);

		nicvf_unregister_interrupts(nic);

		return 1;

		return -EIO;

	}



	return 0;