Commit c6887023 authored by Dario Binacchi's avatar Dario Binacchi Committed by Marc Kleine-Budde
Browse files

can: slcan: do not sleep with a spin lock held 

We can't call close_candev() with a spin lock held, so release the lock
before calling it. After calling close_candev(), we can update the
fields of the private `struct can_priv' without having to acquire the
lock.

Fixes: c4e54b06 ("can: slcan: use CAN network device driver API")
Link: https://lore.kernel.org/linux-kernel/Ysrf1Yc5DaRGN1WE@xsang-OptiPlex-9020/
Link: https://lore.kernel.org/all/20220715072951.859586-1-dario.binacchi@amarulasolutions.com


Reported-by: default avatarkernel test robot <oliver.sang@intel.com>
Signed-off-by: default avatarDario Binacchi <dario.binacchi@amarulasolutions.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent cc944c89

drivers/net/can/slcan/slcan-core.c

+3 −4
Original line number Diff line number Diff line
@@ -688,15 +688,14 @@ static int slc_close(struct net_device *dev) 
		clear_bit(TTY_DO_WRITE_WAKEUP, &sl->tty->flags);

	}

	netif_stop_queue(dev);

	sl->rcount   = 0;

	sl->xleft    = 0;

	spin_unlock_bh(&sl->lock);

	close_candev(dev);

	sl->can.state = CAN_STATE_STOPPED;

	if (sl->can.bittiming.bitrate == CAN_BITRATE_UNKNOWN)

		sl->can.bittiming.bitrate = CAN_BITRATE_UNSET;



	sl->rcount   = 0;

	sl->xleft    = 0;

	spin_unlock_bh(&sl->lock);



	return 0;

}