Commit c680c6a8 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Bartosz Golaszewski
Browse files

gpio: sim: Use correct order for the parameters of devm_kcalloc() 



We should have 'n', then 'size', not the opposite.
This is harmless because the 2 values are just multiplied, but having
the correct order silence a (unpublished yet) smatch warning.

Fixes: cb8c474e ("gpio: sim: new testing module")
Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarBartosz Golaszewski <brgl@bgdev.pl>
parent 7869b481

drivers/gpio/gpio-sim.c

+2 −2
Original line number Diff line number Diff line
@@ -314,8 +314,8 @@ static int gpio_sim_setup_sysfs(struct gpio_sim_chip *chip) 


	for (i = 0; i < num_lines; i++) {

		attr_group = devm_kzalloc(dev, sizeof(*attr_group), GFP_KERNEL);

		attrs = devm_kcalloc(dev, sizeof(*attrs),

				     GPIO_SIM_NUM_ATTRS, GFP_KERNEL);

		attrs = devm_kcalloc(dev, GPIO_SIM_NUM_ATTRS, sizeof(*attrs),

				     GFP_KERNEL);

		val_attr = devm_kzalloc(dev, sizeof(*val_attr), GFP_KERNEL);

		pull_attr = devm_kzalloc(dev, sizeof(*pull_attr), GFP_KERNEL);

		if (!attr_group || !attrs || !val_attr || !pull_attr)