Commit c66cd19e authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: remove RT_PRINT_DATA macro 



Remove RT_PRINT_DATA definition from include/rtw_debug.h, and its
two calling statements in hal/hal_com.c, as this code was not written
with best practices in mind and is safer to simply remove.

Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210731235648.67642-1-phil@philpotter.co.uk


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 55dfa29b

drivers/staging/r8188eu/hal/hal_com.c

+0 −7
Original line number Diff line number Diff line
@@ -339,18 +339,11 @@ s32 c2h_evt_read(struct adapter *adapter, u8 *buf) 
	*buf = rtw_read8(adapter, REG_C2HEVT_MSG_NORMAL);

	*(buf+1) = rtw_read8(adapter, REG_C2HEVT_MSG_NORMAL + 1);



	RT_PRINT_DATA(_module_hal_init_c_, _drv_info_, "c2h_evt_read(): ",

		      &c2h_evt, sizeof(c2h_evt));



	/* Read the content */

	for (i = 0; i < c2h_evt->plen; i++)

		c2h_evt->payload[i] = rtw_read8(adapter, REG_C2HEVT_MSG_NORMAL +

						sizeof(*c2h_evt) + i);



	RT_PRINT_DATA(_module_hal_init_c_, _drv_info_,

		      "c2h_evt_read(): Command Content:\n",

		      c2h_evt->payload, c2h_evt->plen);



	ret = _SUCCESS;



clear_evt:

drivers/staging/r8188eu/include/rtw_debug.h

+0 −18
Original line number Diff line number Diff line
@@ -81,24 +81,6 @@ extern u32 GlobalDebugLevel; 
		}							\

	} while (0)



#define RT_PRINT_DATA(_comp, _level, _titlestring, _hexdata, _hexdatalen)\

	do {								\

		if (_level <= GlobalDebugLevel) {			\

			int __i;					\

			u8	*ptr = (u8 *)_hexdata;			\

			pr_info("%s", DRIVER_PREFIX);			\

			pr_info(_titlestring);				\

			for (__i = 0; __i < (int)_hexdatalen; __i++ ) {	\

				pr_info("%02X%s", ptr[__i],		\

					 (((__i + 1) % 4) == 0) ?	\

					 "  " : " ");	\

				if (((__i + 1) % 16) == 0)		\

					printk("\n");			\

			}						\

			printk("\n");					\

		}							\

	} while (0)



int proc_get_drv_version(char *page, char **start,

			 off_t offset, int count,

			 int *eof, void *data);