Unverified Commit c64e7efe authored by Alain Volmat's avatar Alain Volmat Committed by Mark Brown
Browse files

spi: stm32: make spurious and overrun interrupts visible 



We do not expect to receive spurious interrupts so rise a warning
if it happens.

RX overrun is an error condition that signals a corrupted RX
stream both in dma and in irq modes. Report the error and
abort the transfer in either cases.

Signed-off-by: default avatarAlain Volmat <alain.volmat@foss.st.com>
Link: https://lore.kernel.org/r/1612551572-495-9-git-send-email-alain.volmat@foss.st.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e1e2093b

drivers/spi/spi-stm32.c

+4 −11
Original line number Diff line number Diff line
@@ -895,7 +895,7 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) 
		mask |= STM32H7_SPI_SR_RXP;



	if (!(sr & mask)) {

		dev_dbg(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n",

		dev_warn(spi->dev, "spurious IT (sr=0x%08x, ier=0x%08x)\n",

			 sr, ier);

		spin_unlock_irqrestore(&spi->lock, flags);

		return IRQ_NONE;
@@ -923,14 +923,7 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) 
	}



	if (sr & STM32H7_SPI_SR_OVR) {

		dev_warn(spi->dev, "Overrun: received value discarded\n");

		if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0)))

			stm32h7_spi_read_rxfifo(spi, false);

		/*

		 * If overrun is detected while using DMA, it means that

		 * something went wrong, so stop the current transfer

		 */

		if (spi->cur_usedma)

		dev_err(spi->dev, "Overrun: RX data lost\n");

		end = true;

	}