Commit c63aed73 authored by Rob Herring's avatar Rob Herring Committed by Lorenzo Pieralisi
Browse files

PCI: altera: Use pci_host_probe() to register host 

The altera host driver does the same host registration and bus scanning
calls as pci_host_probe, so let's use it instead.

The only difference is pci_assign_unassigned_bus_resources() was called
instead of pci_bus_size_bridges() and pci_bus_assign_resources(). This
should be the same.

Link: https://lore.kernel.org/r/20200522234832.954484-11-robh@kernel.org


Signed-off-by: default avatarRob Herring <robh@kernel.org>
Signed-off-by: default avatarLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: default avatarLey Foon Tan <ley.foon.tan@intel.com>
Cc: Ley Foon Tan <ley.foon.tan@intel.com>
Cc: rfi@lists.rocketboards.org
parent 97c5372a

drivers/pci/controller/pcie-altera.c

+1 −16
Original line number Diff line number Diff line
@@ -773,8 +773,6 @@ static int altera_pcie_probe(struct platform_device *pdev) 
{

	struct device *dev = &pdev->dev;

	struct altera_pcie *pcie;

	struct pci_bus *bus;

	struct pci_bus *child;

	struct pci_host_bridge *bridge;

	int ret;

	const struct of_device_id *match;
@@ -825,20 +823,7 @@ static int altera_pcie_probe(struct platform_device *pdev) 
	bridge->map_irq = of_irq_parse_and_map_pci;

	bridge->swizzle_irq = pci_common_swizzle;



	ret = pci_scan_root_bus_bridge(bridge);

	if (ret < 0)

		return ret;



	bus = bridge->bus;



	pci_assign_unassigned_bus_resources(bus);



	/* Configure PCI Express setting. */

	list_for_each_entry(child, &bus->children, node)

		pcie_bus_configure_settings(child);



	pci_bus_add_devices(bus);

	return ret;

	return pci_host_probe(bridge);

}



static int altera_pcie_remove(struct platform_device *pdev)