Commit c5d692a2 authored by Tom Rix's avatar Tom Rix Committed by Herbert Xu
Browse files

crypto: hisilicon - cleanup warning in qm_get_qos_value() 



Building with clang static analysis returns this warning:

qm.c:4382:11: warning: The left operand of '==' is a garbage value
        if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {
            ~~~~ ^

The call to qm_qos_value_init() can return an error without setting
*val.  So check ret before checking *val.

Fixes: 72b010dc ("crypto: hisilicon/qm - supports writing QoS int the host")
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 304b4ace

drivers/crypto/hisilicon/qm.c

+1 −1
Original line number Diff line number Diff line
@@ -4394,7 +4394,7 @@ static ssize_t qm_get_qos_value(struct hisi_qm *qm, const char *buf, 
		return -EINVAL;



	ret = qm_qos_value_init(val_buf, val);

	if (*val == 0 || *val > QM_QOS_MAX_VAL || ret) {

	if (ret || *val == 0 || *val > QM_QOS_MAX_VAL) {

		pci_err(qm->pdev, "input qos value is error, please set 1~1000!\n");

		return -EINVAL;

	}