Commit c5cb2cdf authored by Chandan Vurdigere Nataraj's avatar Chandan Vurdigere Nataraj Committed by Alex Deucher
Browse files

drm/amd/display: Re-org and cleanup the redundant code 



[Why]
Redundant if-else cases for repeater and non-repeater checks

[How]
Without changing the core logic, rearranged the code by removing
redundant checks

Signed-off-by: default avatarChandan Vurdigere Nataraj <chandan.vurdigerenataraj@amd.com>
Reviewed-by: default avatarLeo Li <sunpeng.li@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent ff15cea3

drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c

+7 −9
Original line number Diff line number Diff line
@@ -913,19 +913,10 @@ enum dc_status dp_get_lane_status_and_lane_adjust( 
			offset,

			lane01_status_address, dpcd_buf[0],

			lane01_status_address + 1, dpcd_buf[1]);

	} else {

		DC_LOG_HW_LINK_TRAINING("%s:\n 0x%X Lane01Status = %x\n 0x%X Lane23Status = %x\n ",

			__func__,

			lane01_status_address, dpcd_buf[0],

			lane01_status_address + 1, dpcd_buf[1]);

	}

	lane01_adjust_address = DP_ADJUST_REQUEST_LANE0_1;



	if (is_repeater(link, offset))

		lane01_adjust_address = DP_ADJUST_REQUEST_LANE0_1_PHY_REPEATER1 +

				((DP_REPEATER_CONFIGURATION_AND_STATUS_SIZE) * (offset - 1));



	if (is_repeater(link, offset)) {

		DC_LOG_HW_LINK_TRAINING("%s:\n LTTPR Repeater ID: %d\n"

				" 0x%X Lane01AdjustRequest = %x\n 0x%X Lane23AdjustRequest = %x\n",

					__func__,
@@ -935,6 +926,13 @@ enum dc_status dp_get_lane_status_and_lane_adjust( 
					lane01_adjust_address + 1,

					dpcd_buf[lane_adjust_offset + 1]);

	} else {

		DC_LOG_HW_LINK_TRAINING("%s:\n 0x%X Lane01Status = %x\n 0x%X Lane23Status = %x\n ",

			__func__,

			lane01_status_address, dpcd_buf[0],

			lane01_status_address + 1, dpcd_buf[1]);



		lane01_adjust_address = DP_ADJUST_REQUEST_LANE0_1;



		DC_LOG_HW_LINK_TRAINING("%s:\n 0x%X Lane01AdjustRequest = %x\n 0x%X Lane23AdjustRequest = %x\n",

			__func__,

			lane01_adjust_address,