Commit c5b0a7ee authored by Vincent Guittot's avatar Vincent Guittot Committed by Peter Zijlstra
Browse files

sched/fair: Remove sysctl_sched_migration_cost condition 



With a default value of 500us, sysctl_sched_migration_cost is
significanlty higher than the cost of load_balance. Remove the
condition and rely on the sd->max_newidle_lb_cost to abort
newidle_balance.

Suggested-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: default avatarDietmar Eggemann <dietmar.eggemann@arm.com>
Acked-by: default avatarMel Gorman <mgorman@suse.de>
Link: https://lore.kernel.org/r/20211019123537.17146-5-vincent.guittot@linaro.org
parent e60b56e4

kernel/sched/fair.c

+1 −2
Original line number Diff line number Diff line
@@ -10895,8 +10895,7 @@ static int newidle_balance(struct rq *this_rq, struct rq_flags *rf) 
	rcu_read_lock();

	sd = rcu_dereference_check_sched_domain(this_rq->sd);



	if (this_rq->avg_idle < sysctl_sched_migration_cost ||

	    !READ_ONCE(this_rq->rd->overload) ||

	if (!READ_ONCE(this_rq->rd->overload) ||

	    (sd && this_rq->avg_idle < sd->max_newidle_lb_cost)) {



		if (sd)