Commit c5741c5c authored by Nirmoy Das's avatar Nirmoy Das
Browse files

drm/i915/display: Do not use stolen on MTL 



Use smem on MTL due to a HW bug in MTL that prevents
reading from stolen memory using LMEM BAR.

v2 and v3: improve stolen skip detection(Andrzej)

Cc: Oak Zeng <oak.zeng@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: default avatarNirmoy Das <nirmoy.das@intel.com>
Reviewed-by: default avatarOak Zeng <oak.zeng@intel.com>
Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: default avatarAndi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230713150142.12700-2-nirmoy.das@intel.com
parent 290d1610

drivers/gpu/drm/i915/display/intel_fbdev.c

+3 −1
Original line number Diff line number Diff line
@@ -182,8 +182,10 @@ static int intelfb_alloc(struct drm_fb_helper *helper, 
		 * If the FB is too big, just don't use it since fbdev is not very

		 * important and we should probably use that space with FBC or other

		 * features.

		 *

		 * Also skip stolen on MTL as Wa_22018444074 mitigation.

		 */

		if (size * 2 < dev_priv->dsm.usable_size)

		if (!(IS_METEORLAKE(dev_priv)) && size * 2 < dev_priv->dsm.usable_size)

			obj = i915_gem_object_create_stolen(dev_priv, size);

		if (IS_ERR(obj))

			obj = i915_gem_object_create_shmem(dev_priv, size);

drivers/gpu/drm/i915/display/intel_overlay.c

+3 −2
Original line number Diff line number Diff line
@@ -1348,10 +1348,11 @@ int intel_overlay_attrs_ioctl(struct drm_device *dev, void *data, 
static int get_registers(struct intel_overlay *overlay, bool use_phys)

{

	struct drm_i915_private *i915 = overlay->i915;

	struct drm_i915_gem_object *obj;

	struct drm_i915_gem_object *obj = ERR_PTR(-ENODEV);

	struct i915_vma *vma;

	int err;



	if (!IS_METEORLAKE(i915)) /* Wa_22018444074 */

		obj = i915_gem_object_create_stolen(i915, PAGE_SIZE);

	if (IS_ERR(obj))

		obj = i915_gem_object_create_internal(i915, PAGE_SIZE);