Commit c5491d8a authored by Ma Ke's avatar Ma Ke Committed by Liu Chuang
Browse files

drm/panel/panel-tpo-tpg110: fix a possible null pointer dereference 

stable inclusion
from stable-v5.10.202
commit 9acc2bc00135e9ecd13a70ce1140e2673e504cdc
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I9TCIL
CVE: CVE-2023-52826

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=9acc2bc00135e9ecd13a70ce1140e2673e504cdc



--------------------------------

[ Upstream commit f22def5970c423ea7f87d5247bd0ef91416b0658 ]

In tpg110_get_modes(), the return value of drm_mode_duplicate() is
assigned to mode, which will lead to a NULL pointer dereference on
failure of drm_mode_duplicate(). Add a check to avoid npd.

Signed-off-by: default avatarMa Ke <make_ruc2021@163.com>
Reviewed-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20231009090446.4043798-1-make_ruc2021@163.com


Signed-off-by: default avatarNeil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231009090446.4043798-1-make_ruc2021@163.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarLiu Chuang <liuchuang40@huawei.com>
parent ad0b926e

drivers/gpu/drm/panel/panel-tpo-tpg110.c

+2 −0
Original line number Diff line number Diff line
@@ -378,6 +378,8 @@ static int tpg110_get_modes(struct drm_panel *panel, 
	connector->display_info.bus_flags = tpg->panel_mode->bus_flags;



	mode = drm_mode_duplicate(connector->dev, &tpg->panel_mode->mode);

	if (!mode)

		return -ENOMEM;

	drm_mode_set_name(mode);

	mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;