Commit c4fc88ad authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Jakub Kicinski
Browse files

net: stmmac: fix double serdes powerdown 



Commit 49725ffc ("net: stmmac: power up/down serdes in
stmmac_open/release") correctly added a call to the serdes_powerdown()
callback to stmmac_release() but did not remove the one from
stmmac_remove() which leads to a doubled call to serdes_powerdown().

This can lead to all kinds of problems: in the case of the qcom ethqos
driver, it caused an unbalanced regulator disable splat.

Fixes: 49725ffc ("net: stmmac: power up/down serdes in stmmac_open/release")
Signed-off-by: default avatarBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Acked-by: default avatarJunxiao Chang <junxiao.chang@intel.com>
Reviewed-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Tested-by: default avatarAndrew Halaney <ahalaney@redhat.com>
Link: https://lore.kernel.org/r/20230621135537.376649-1-brgl@bgdev.pl


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent b9ec61be

drivers/net/ethernet/stmicro/stmmac/stmmac_main.c

+0 −6
Original line number Diff line number Diff line
@@ -7457,12 +7457,6 @@ void stmmac_dvr_remove(struct device *dev) 
	netif_carrier_off(ndev);

	unregister_netdev(ndev);



	/* Serdes power down needs to happen after VLAN filter

	 * is deleted that is triggered by unregister_netdev().

	 */

	if (priv->plat->serdes_powerdown)

		priv->plat->serdes_powerdown(ndev, priv->plat->bsp_priv);



#ifdef CONFIG_DEBUG_FS

	stmmac_exit_fs(ndev);

#endif