Commit c4e21bcd authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Jens Axboe
Browse files

block: cleanup queue_wc_store 



Get rid of the local queue_wc_store variable and handling setting and
clearing the QUEUE_FLAG_WC flag diretly instead the if / else if.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20230707094239.107968-2-hch@lst.de


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent ffe357c8

block/blk-sysfs.c

+3 −11
Original line number Diff line number Diff line
@@ -449,21 +449,13 @@ static ssize_t queue_wc_show(struct request_queue *q, char *page) 
static ssize_t queue_wc_store(struct request_queue *q, const char *page,

			      size_t count)

{

	int set = -1;



	if (!strncmp(page, "write back", 10))

		set = 1;

		blk_queue_flag_set(QUEUE_FLAG_WC, q);

	else if (!strncmp(page, "write through", 13) ||

		 !strncmp(page, "none", 4))

		set = 0;



	if (set == -1)

		return -EINVAL;



	if (set)

		blk_queue_flag_set(QUEUE_FLAG_WC, q);

	else

		blk_queue_flag_clear(QUEUE_FLAG_WC, q);

	else

		return -EINVAL;



	return count;

}