Commit c4a146c7 authored by Tony Lu's avatar Tony Lu Committed by David S. Miller
Browse files

net/smc: Fix smc_link->llc_testlink_time overflow 



The value of llc_testlink_time is set to the value stored in
net->ipv4.sysctl_tcp_keepalive_time when linkgroup init. The value of
sysctl_tcp_keepalive_time is already jiffies, so we don't need to
multiply by HZ, which would cause smc_link->llc_testlink_time overflow,
and test_link send flood.

Signed-off-by: default avatarTony Lu <tonylu@linux.alibaba.com>
Reviewed-by: default avatarXuan Zhuo <xuanzhuo@linux.alibaba.com>
Reviewed-by: default avatarWen Gu <guwen@linux.alibaba.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 90a881fc

net/smc/smc_llc.c

+1 −1
Original line number Diff line number Diff line
@@ -1822,7 +1822,7 @@ void smc_llc_link_active(struct smc_link *link) 
			    link->smcibdev->ibdev->name, link->ibport);

	link->state = SMC_LNK_ACTIVE;

	if (link->lgr->llc_testlink_time) {

		link->llc_testlink_time = link->lgr->llc_testlink_time * HZ;

		link->llc_testlink_time = link->lgr->llc_testlink_time;

		schedule_delayed_work(&link->llc_testlink_wrk,

				      link->llc_testlink_time);

	}