Commit c4208653 authored by Sasha Neftin's avatar Sasha Neftin Committed by Tony Nguyen
Browse files

igc: igc_write_phy_reg_gpy: drop premature return 



Similar to "igc_read_phy_reg_gpy: drop premature return" patch.
igc_write_phy_reg_gpy checks the return value from igc_write_phy_reg_mdic
and if it's not 0, returns immediately. By doing this, it leaves the HW
semaphore in the acquired state.

Drop this premature return statement, the function returns after
releasing the semaphore immediately anyway.

Fixes: 5586838f ("igc: Add code for PHY support")
Suggested-by: default avatarDima Ruinskiy <dima.ruinskiy@intel.com>
Reported-by: default avatarCorinna Vinschen <vinschen@redhat.com>
Signed-off-by: default avatarSasha Neftin <sasha.neftin@intel.com>
Tested-by: default avatarNaama Meir <naamax.meir@linux.intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent fda26354

drivers/net/ethernet/intel/igc/igc_phy.c

+0 −2
Original line number Diff line number Diff line
@@ -746,8 +746,6 @@ s32 igc_write_phy_reg_gpy(struct igc_hw *hw, u32 offset, u16 data) 
		if (ret_val)

			return ret_val;

		ret_val = igc_write_phy_reg_mdic(hw, offset, data);

		if (ret_val)

			return ret_val;

		hw->phy.ops.release(hw);

	} else {

		ret_val = igc_write_xmdio_reg(hw, (u16)offset, dev_addr,