Commit c4151604 authored Dec 21, 2020 by Lukas Bulwahn Committed by Rafael J. Wysocki Jan 07, 2021

cpufreq: intel_pstate: remove obsolete functions



percent_fp() was used in intel_pstate_pid_reset(), which was removed in
commit 9d0ef7af ("cpufreq: intel_pstate: Do not use PID-based P-state
selection") and hence, percent_fp() is unused since then.

percent_ext_fp() was last used in intel_pstate_update_perf_limits(), which
was refactored in commit 1a4fe38a ("cpufreq: intel_pstate: Remove
max/min fractions to limit performance"), and hence, percent_ext_fp() is
unused since then.

make CC=clang W=1 points us those unused functions:

drivers/cpufreq/intel_pstate.c:79:23: warning: unused function 'percent_fp' [-Wunused-function]
static inline int32_t percent_fp(int percent)
                      ^

drivers/cpufreq/intel_pstate.c:94:23: warning: unused function 'percent_ext_fp' [-Wunused-function]
static inline int32_t percent_ext_fp(int percent)
                      ^

Remove those obsolete functions.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 943bdd0c

drivers/cpufreq/intel_pstate.c

+0 −10

Original line number	Diff line number	Diff line
		@@ -76,11 +76,6 @@ static inline int ceiling_fp(int32_t x)
		return ret;
		}

		static inline int32_t percent_fp(int percent)
		{
		return div_fp(percent, 100);
		}

		static inline u64 mul_ext_fp(u64 x, u64 y)
		{
		return (x * y) >> EXT_FRAC_BITS;
		@@ -91,11 +86,6 @@ static inline u64 div_ext_fp(u64 x, u64 y)
		return div64_u64(x << EXT_FRAC_BITS, y);
		}

		static inline int32_t percent_ext_fp(int percent)
		{
		return div_ext_fp(percent, 100);
		}

		/**
		* struct sample - Store performance sample
		* @core_avg_perf: Ratio of APERF/MPERF which is the actual average