Commit c4039b29 authored by Dan Carpenter's avatar Dan Carpenter Committed by Ard Biesheuvel
Browse files

efi/libstub: prevent read overflow in find_file_option() 



If the buffer has slashes up to the end then this will read past the end
of the array.  I don't anticipate that this is an issue for many people
in real life, but it's the right thing to do and it makes static
checkers happy.

Fixes: 7a88a622 ("efi/libstub: Fix path separator regression")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarArd Biesheuvel <ardb@kernel.org>
parent 45add3cc

drivers/firmware/efi/libstub/file.c

+1 −1
Original line number Diff line number Diff line
@@ -103,7 +103,7 @@ static int find_file_option(const efi_char16_t *cmdline, int cmdline_len, 
		return 0;



	/* Skip any leading slashes */

	while (cmdline[i] == L'/' || cmdline[i] == L'\\')

	while (i < cmdline_len && (cmdline[i] == L'/' || cmdline[i] == L'\\'))

		i++;



	while (--result_len > 0 && i < cmdline_len) {