Commit c3daa475 authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Daniel Lezcano
Browse files

clocksource/drivers/sh_cmt: Mark driver as non-removable 



The comment in the remove callback suggests that the driver is not
supposed to be unbound. However returning an error code in the remove
callback doesn't accomplish that. Instead set the suppress_bind_attrs
property (which makes it impossible to unbind the driver via sysfs).
The only remaining way to unbind a sh_cmt device would be module
unloading, but that doesn't apply here, as the driver cannot be built as
a module.

Also drop the useless remove callback.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230123220221.48164-1-u.kleine-koenig@pengutronix.de


Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
parent 8d17aca9

drivers/clocksource/sh_cmt.c

+1 −6
Original line number Diff line number Diff line
@@ -1145,17 +1145,12 @@ static int sh_cmt_probe(struct platform_device *pdev) 
	return 0;

}



static int sh_cmt_remove(struct platform_device *pdev)

{

	return -EBUSY; /* cannot unregister clockevent and clocksource */

}



static struct platform_driver sh_cmt_device_driver = {

	.probe		= sh_cmt_probe,

	.remove		= sh_cmt_remove,

	.driver		= {

		.name	= "sh_cmt",

		.of_match_table = of_match_ptr(sh_cmt_of_table),

		.suppress_bind_attrs = true,

	},

	.id_table	= sh_cmt_id_table,

};