Commit c3c14ecf authored by Bjorn Helgaas's avatar Bjorn Helgaas Committed by Tony Nguyen
Browse files

igc: Remove redundant pci_enable_pcie_error_reporting() 



pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since f26e58bf ("PCI/AER: Enable error reporting when AER is
native"), the PCI core does this for all devices during enumeration.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this doesn't control interrupt generation by the Root Port; that
is controlled by the AER Root Error Command register, which is managed by
the AER service driver.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org
Tested-by: default avatarNaama Meir <naamax.meir@linux.intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 8aea4c32

drivers/net/ethernet/intel/igc/igc_main.c

+0 −5
Original line number Diff line number Diff line
@@ -6434,8 +6434,6 @@ static int igc_probe(struct pci_dev *pdev, 
	if (err)

		goto err_pci_reg;



	pci_enable_pcie_error_reporting(pdev);



	err = pci_enable_ptm(pdev, NULL);

	if (err < 0)

		dev_info(&pdev->dev, "PCIe PTM not supported by PCIe bus/controller\n");
@@ -6640,7 +6638,6 @@ static int igc_probe(struct pci_dev *pdev, 
err_ioremap:

	free_netdev(netdev);

err_alloc_etherdev:

	pci_disable_pcie_error_reporting(pdev);

	pci_release_mem_regions(pdev);

err_pci_reg:

err_dma:
@@ -6688,8 +6685,6 @@ static void igc_remove(struct pci_dev *pdev) 


	free_netdev(netdev);



	pci_disable_pcie_error_reporting(pdev);



	pci_disable_device(pdev);

}