Commit c3b9d21e authored by AngeloGioacchino Del Regno's avatar AngeloGioacchino Del Regno Committed by Chun-Kuang Hu
Browse files

drm/mediatek: dp: Move AUX_P0 setting to mtk_dp_initialize_aux_settings() 



Move the register write to MTK_DP_AUX_P0_3690 to set the AUX reply mode
to function mtk_dp_initialize_aux_settings(), as this is effectively
part of the DPTX AUX setup sequence.

Signed-off-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Tested-by: default avatarChen-Yu Tsai <wenst@chromium.org>
Reviewed-by: default avatarCK Hu <ck.hu@mediatek.com>
Reviewed-by: default avatarAlexandre Mergnat <amergnat@baylibre.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20230725073234.55892-6-angelogioacchino.delregno@collabora.com/


Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
parent 214a0944

drivers/gpu/drm/mediatek/mtk_dp.c

+5 −4
Original line number Diff line number Diff line
@@ -1009,6 +1009,11 @@ static void mtk_dp_initialize_aux_settings(struct mtk_dp *mtk_dp) 
	mtk_dp_update_bits(mtk_dp, MTK_DP_AUX_P0_37C8,

			   MTK_ATOP_EN_AUX_TX_P0,

			   MTK_ATOP_EN_AUX_TX_P0);



	/* Set complete reply mode for AUX */

	mtk_dp_update_bits(mtk_dp, MTK_DP_AUX_P0_3690,

			   RX_REPLY_COMPLETE_MODE_AUX_TX_P0,

			   RX_REPLY_COMPLETE_MODE_AUX_TX_P0);

}



static void mtk_dp_initialize_digital_settings(struct mtk_dp *mtk_dp)
@@ -1826,10 +1831,6 @@ static void mtk_dp_init_port(struct mtk_dp *mtk_dp) 
	mtk_dp_initialize_settings(mtk_dp);

	mtk_dp_initialize_aux_settings(mtk_dp);

	mtk_dp_initialize_digital_settings(mtk_dp);



	mtk_dp_update_bits(mtk_dp, MTK_DP_AUX_P0_3690,

			   RX_REPLY_COMPLETE_MODE_AUX_TX_P0,

			   RX_REPLY_COMPLETE_MODE_AUX_TX_P0);

	mtk_dp_initialize_hpd_detect_settings(mtk_dp);



	mtk_dp_digital_sw_reset(mtk_dp);