Commit c3b948be authored by Allison Henderson's avatar Allison Henderson Committed by Dave Chinner
Browse files

xfs: add leaf split error tag 



Add an error tag on xfs_da3_split to test log attribute recovery
and replay.

Signed-off-by: default avatarCatherine Hoang <catherine.hoang@oracle.com>
Reviewed-by: default avatarAllison Henderson <allison.henderson@oracle.com>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Reviewed-by: default avatarChandan Babu R <chandan.babu@oracle.com>
Signed-off-by: default avatarAllison Henderson <allison.henderson@oracle.com>
Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
parent c3546cf5

fs/xfs/libxfs/xfs_da_btree.c

+4 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ 
#include "xfs_trace.h"

#include "xfs_buf_item.h"

#include "xfs_log.h"

#include "xfs_errortag.h"



/*

 * xfs_da_btree.c
@@ -482,6 +483,9 @@ xfs_da3_split( 


	trace_xfs_da_split(state->args);



	if (XFS_TEST_ERROR(false, state->mp, XFS_ERRTAG_DA_LEAF_SPLIT))

		return -EIO;



	/*

	 * Walk back up the tree splitting/inserting/adjusting as necessary.

	 * If we need to insert and there isn't room, split the node, then

fs/xfs/libxfs/xfs_errortag.h

+3 −1
Original line number Diff line number Diff line
@@ -60,7 +60,8 @@ 
#define XFS_ERRTAG_BMAP_ALLOC_MINLEN_EXTENT		37

#define XFS_ERRTAG_AG_RESV_FAIL				38

#define XFS_ERRTAG_LARP					39

#define XFS_ERRTAG_MAX					40

#define XFS_ERRTAG_DA_LEAF_SPLIT			40

#define XFS_ERRTAG_MAX					41



/*

 * Random factors for above tags, 1 means always, 2 means 1/2 time, etc.
@@ -105,5 +106,6 @@ 
#define XFS_RANDOM_BMAP_ALLOC_MINLEN_EXTENT		1

#define XFS_RANDOM_AG_RESV_FAIL				1

#define XFS_RANDOM_LARP					1

#define XFS_RANDOM_DA_LEAF_SPLIT			1



#endif /* __XFS_ERRORTAG_H_ */

fs/xfs/xfs_error.c

+3 −0
Original line number Diff line number Diff line
@@ -58,6 +58,7 @@ static unsigned int xfs_errortag_random_default[] = { 
	XFS_RANDOM_BMAP_ALLOC_MINLEN_EXTENT,

	XFS_RANDOM_AG_RESV_FAIL,

	XFS_RANDOM_LARP,

	XFS_RANDOM_DA_LEAF_SPLIT,

};



struct xfs_errortag_attr {
@@ -172,6 +173,7 @@ XFS_ERRORTAG_ATTR_RW(reduce_max_iextents, XFS_ERRTAG_REDUCE_MAX_IEXTENTS); 
XFS_ERRORTAG_ATTR_RW(bmap_alloc_minlen_extent,	XFS_ERRTAG_BMAP_ALLOC_MINLEN_EXTENT);

XFS_ERRORTAG_ATTR_RW(ag_resv_fail, XFS_ERRTAG_AG_RESV_FAIL);

XFS_ERRORTAG_ATTR_RW(larp,		XFS_ERRTAG_LARP);

XFS_ERRORTAG_ATTR_RW(da_leaf_split,	XFS_ERRTAG_DA_LEAF_SPLIT);



static struct attribute *xfs_errortag_attrs[] = {

	XFS_ERRORTAG_ATTR_LIST(noerror),
@@ -214,6 +216,7 @@ static struct attribute *xfs_errortag_attrs[] = { 
	XFS_ERRORTAG_ATTR_LIST(bmap_alloc_minlen_extent),

	XFS_ERRORTAG_ATTR_LIST(ag_resv_fail),

	XFS_ERRORTAG_ATTR_LIST(larp),

	XFS_ERRORTAG_ATTR_LIST(da_leaf_split),

	NULL,

};

ATTRIBUTE_GROUPS(xfs_errortag);