Commit c39013ee authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

kbuild: clean up ${quiet} checks in shell scripts 



There were efforts to make 'make -s' really silent when it is a
warning-free build.

The conventional way was to let a shell script check ${quiet}, and if
it is 'silent_', suppress the stdout by itself.

With the previous commit, the 'cmd' takes care of it now. The 'cmd' is
also invoked from if_changed, if_changed_dep, and if_changed_rule.

You can omit ${quiet} checks in shell scripts when they are invoked
from the 'cmd' macro.

Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent 174a1dcc

kernel/gen_kheaders.sh

+1 −3
Original line number Diff line number Diff line
@@ -56,9 +56,7 @@ if [ -f kernel/kheaders.md5 ] && 
		exit

fi



if [ "${quiet}" != "silent_" ]; then

echo "  GEN     $tarfile"

fi



rm -rf $cpio_dir

mkdir $cpio_dir

scripts/link-vmlinux.sh

+1 −3
Original line number Diff line number Diff line
@@ -38,9 +38,7 @@ LDFLAGS_vmlinux="$3" 
# Will be supressed by "make -s"

info()

{

	if [ "${quiet}" != "silent_" ]; then

	printf "  %-7s %s\n" "${1}" "${2}"

	fi

}



# Generate a linker script to ensure correct ordering of initcalls.

scripts/mkcompile_h

+1 −3
Original line number Diff line number Diff line
@@ -9,8 +9,6 @@ PREEMPT_RT=$5 
CC_VERSION="$6"

LD=$7



vecho() { [ "${quiet}" = "silent_" ] || echo "$@" ; }



# Do not expand names

set -f
@@ -82,7 +80,7 @@ if [ -r $TARGET ] && \ 
      cmp -s .tmpver.1 .tmpver.2; then

   rm -f .tmpcompile

else

   vecho "  UPD     $TARGET"

   echo "  UPD     $TARGET"

   mv -f .tmpcompile $TARGET

fi

rm -f .tmpver.1 .tmpver.2