Commit c367602a authored by David Sterba's avatar David Sterba
Browse files

btrfs: remove node and parent parameters from insert_state 



There's no caller left that would pass valid pointers to insert_state so
we can drop them.

Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent fb8f07d2

fs/btrfs/extent_io.c

+2 −12
Original line number Diff line number Diff line
@@ -525,8 +525,6 @@ static void set_state_bits(struct extent_io_tree *tree, 
 */

static int insert_state(struct extent_io_tree *tree,

			struct extent_state *state,

			struct rb_node ***node_in,

			struct rb_node **parent_in,

			u32 bits, struct extent_changeset *changeset)

{

	struct rb_node **node;
@@ -535,13 +533,6 @@ static int insert_state(struct extent_io_tree *tree, 


	set_state_bits(tree, state, bits, changeset);



	/* Caller provides the exact tree location */

	if (node_in && parent_in) {

		node = *node_in;

		parent = *parent_in;

		goto insert_new;

	}



	node = &tree->state.rb_node;

	while (*node) {

		struct tree_entry *entry;
@@ -561,7 +552,6 @@ static int insert_state(struct extent_io_tree *tree, 
		}

	}



insert_new:

	rb_link_node(&state->rb_node, parent, node);

	rb_insert_color(&state->rb_node, &tree->state);
@@ -1150,7 +1140,7 @@ int set_extent_bit(struct extent_io_tree *tree, u64 start, u64 end, u32 bits, 
		 */

		prealloc->start = start;

		prealloc->end = this_end;

		err = insert_state(tree, prealloc, NULL, NULL, bits, changeset);

		err = insert_state(tree, prealloc, bits, changeset);

		if (err)

			extent_io_tree_panic(tree, err);
@@ -1371,7 +1361,7 @@ int convert_extent_bit(struct extent_io_tree *tree, u64 start, u64 end, 
		 */

		prealloc->start = start;

		prealloc->end = this_end;

		err = insert_state(tree, prealloc, NULL, NULL, bits, NULL);

		err = insert_state(tree, prealloc, bits, NULL);

		if (err)

			extent_io_tree_panic(tree, err);

		cache_state(prealloc, cached_state);